MS2: Blockly Editor for Script Tasks

[LucasMGo]

Summary

Added the visual editor blockly for creating script tasks.

Details

• added blockly editor to script tasks
• store blockly script as xml
• convertion of blockly to regular js script

[FelipeTrost]

Just some minor things, but it looks good

Maybe you could also add a loading animation to the script editor, because it initially opens the menu to select between js and blockly and then it jumps to the correct editor.

[FelipeTrost]

Is there a way to check if a block has an empty field, for example if the setVariable block isn't given a value it produces invalid code.

[LucasMGo]

I now changed the js-transformation of the setVariable block so that the default value for setting a variable is null.

[FelipeTrost]

That solves that particular instance of the problem, but I still think we should check for empty fields, I'm going to merge this PR, but I think that we should check them in future

[FelipeTrost]

This will fail if the variableValue is false or undefined and write null instead

[LucasMGo]

This will fail if the variableValue is false or undefined and write null instead

When accessing the value attribute in blockly, the value is always returned as a string by the javascriptGenerator of blockly.
So, when using true (or undefined) as a value in your block, the javascriptGenerator will return a string 'true' (or 'undefined'). Using a word, e.g. "test", in your block, this would result in the string ' "test" '. So if I check for empty values and it is used true or undefined, the check (variableValue || null) would return the variableValue, which is 'true' or 'undefined', because these are just strings and not falsy values. On the other hand, if the block has an empty value, the javascriptGenerator would return the empty string '' which is a falsy value and therefore null is inserted.

[github-actions]

✅ Successfully created Preview Deployment.

https://pr-445---ms-server-staging-c4f6qdpj7q-ew.a.run.app