ms2/engine unified endpoints #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FelipeTrost
force-pushed
the
ms2/engine-unified-endpoints
branch
from
0d64c4c to
09229fe
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
jjoderis
requested changes
Jan 14, 2025
OhKai
reviewed
Jan 20, 2025
src/management-system-v2/app/(dashboard)/[environmentId]/executions/[processId]/page.tsx
Outdated
Show resolved
Hide resolved
...system-v2/app/(dashboard)/[environmentId]/executions/[processId]/process-deployment-view.tsx
Show resolved
Hide resolved
…tions/[processId]/page.tsx Co-authored-by: Kai Rohwer <rohwer.kai@icloud.com>
…s/proceed into ms2/engine-unified-endpoints
|
✅ Successfully created Preview Deployment. |
jjoderis
approved these changes
Jan 26, 2025
| function getLatestVersion(process: DeployedProcessInfo) { | ||
| let latest = process.versions.length - 1; | ||
| for (let i = process.versions.length - 2; i >= 0; i--) { | ||
| if (process.versions[i].version > process.versions[latest].version) latest = i; |
There was a problem hiding this comment.
This does not work with the new version info that contains versionId instead of version which is also not usable to infer which version is the newest.
| for (const deployment of deployments) { | ||
| let latestVesrionIdx = deployment.versions.length - 1; | ||
| for (let i = deployment.versions.length - 2; i >= 0; i--) { | ||
| if (deployment.versions[i].version > deployment.versions[latestVesrionIdx].version) |
There was a problem hiding this comment.
Same problem as in the instance view. I think this will not work correctly since there should not be a version entry in the objects inside versions anymore.
| const ExecutionsPage = async ({ params }: { params: { environmentId: string } }) => { | ||
| function getDeploymentNames(deployments: DeployedProcessInfo[]) { | ||
| for (const deployment of deployments) { | ||
| let latestVesrionIdx = deployment.versions.length - 1; |
| @@ -202,7 +224,6 @@ export type VersionInfo = { | |||
| versionName: string; | |||
There was a problem hiding this comment.
I think you need to replace the version entry above with versionId
|
|
||
| // Endpoints | ||
| type EndpointSchema = typeof import('./endpoints.json'); | ||
| type Endpoints = EndpointSchema; |
There was a problem hiding this comment.
Is this needed because of the json import or could you just do type Endpoints = typeof import('./endpoints.json'); without the EndpointSchema assignment?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Enginewhich includes mqtt/http and space/PROCEED engines.Engineand makes the appropriate request.There are still TODOS in the code, but the basic structure is there.