-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ms2/config versioning #433
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…versions except the latest disabled
…s2/config_versioning
…s latest" now causes navigation to latest version
This comment has been minimized.
This comment has been minimized.
FelipeTrost
requested changes
Dec 12, 2024
...gement-system-v2/app/(dashboard)/[environmentId]/machine-config/[configId]/config-editor.tsx
Outdated
Show resolved
Hide resolved
...gement-system-v2/app/(dashboard)/[environmentId]/machine-config/[configId]/config-editor.tsx
Outdated
Show resolved
Hide resolved
...gement-system-v2/app/(dashboard)/[environmentId]/machine-config/[configId]/config-editor.tsx
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@FelipeTrost are you ready to approve after the changes? |
…s2/config_versioning
This comment has been minimized.
This comment has been minimized.
FelipeTrost
approved these changes
Jan 23, 2025
✅ Successfully created Preview Deployment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This re-enables the versioning for configs/techdata sets in a similar fashion to the process versioning. This state is usable and presentable eventhough some problems still persist. For example linked parameters are currently not referenced correctly when versioned and also deletion of a config may cause version data to stay unreferenced in storage.
Details
versionedParentConfigs
added to the techdata-storeaddParentConfigVersion()
added to store a new version of the current statesetParentConfigVersionAsLatest
added overwrite latest config