Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support JSON type #192

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

redox
Copy link

@redox redox commented Jan 28, 2025

This is similar to #139 but with the newest data type

@PNixx
Copy link
Owner

PNixx commented Feb 13, 2025

@redox please, update your branch from master

@redox redox force-pushed the su/support-json-type branch from 1d0bb9a to 22fb237 Compare February 13, 2025 07:13
@redox
Copy link
Author

redox commented Feb 13, 2025

@redox please, update your branch from master

Good 🫡

@redox
Copy link
Author

redox commented Feb 13, 2025

@PNixx my understanding is that this new JSON type is available as beta since 24.11 only. What's the best way to handle this in the CI from your POV in? Should we just raise when server_version is not suitable?

@@ -4,6 +4,7 @@
<profiles>
<default>
<load_balancing>random</load_balancing>
<enable_json_type>1</enable_json_type>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the problem is in the test errors here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants