Support functions #120
Merged
Support functions #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
And need add dump for |
|
@PNixx added, can you please check |
felix-dumit
force-pushed
the
functions-support
branch
from
e35ca5c to
676a99a
Compare
|
Fixed latest conflicts with master |
|
@PNixx Hi, could you take another look? Anything else I need to change? |
|
@felix-dumit see review questions. |
|
@PNixx Sorry, what questions do you mean? I don't see anything |
|
@PNixx Those say "Pending" so they are only visible for you, you need to submit your review |
PNixx
reviewed
Apr 2, 2024
PNixx
reviewed
Apr 2, 2024
felix-dumit
force-pushed
the
functions-support
branch
from
676a99a to
46b04e2
Compare
PNixx
reviewed
Apr 3, 2024
leboshi
added a commit
to magellan-ai/clickhouse-activerecord
that referenced
this pull request
Apr 20, 2024
Implements 6ad665c
dmitrytrager
added a commit
to mayak-bz/clickhouse-activerecord
that referenced
this pull request
May 20, 2024
* upstream: (39 commits) fix schema dumper for buffer table create table similar to other table published 1.0.7 - fix db tasks published 1.0.6 dump indexes to schema rebuild and clear indexes add support indexes Hotfix/rails71 change column (PNixx#132) Support functions (PNixx#120) Fix precision loss due to JSON float parsing (PNixx#129) fix non-canonical uuid (PNixx#117) refactoring add github workflows, fix spec delete and update, fix injection internal and schema classes for rails 7 add spec for pr PNixx#123 Fix wrong method arguments (PNixx#123) Fix schema_migrations insert failing (PNixx#122) Add support for binary string (PNixx#116) add spec for do_execute method before merge PNixx#116 fix `insert_all` array column refactoring connection config ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Adds support for User-Defined functions dump/load to structure.sql
https://clickhouse.com/docs/en/sql-reference/statements/create/function
Side-Note
I wasn't able to just run the specs in this repo from just cloning it, I had to first create database from the config I had in another repo, in order to then run the specs from this repo. It would be nice to either add some more documentation or make this repo self-contained for running specs.