Fix #find_by (#153)

PNixx · Jul 31, 2024 · fb38675 · fb38675
1 parent 59dc1c2
commit fb38675
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/lib/arel/visitors/clickhouse.rb b/lib/arel/visitors/clickhouse.rb
@@ -16,8 +16,12 @@ def aggregate(name, o, collector)
       # https://clickhouse.com/docs/en/sql-reference/statements/delete
       # DELETE and UPDATE in ClickHouse working only without table name
       def visit_Arel_Attributes_Attribute(o, collector)
-        collector << quote_table_name(o.relation.table_alias || o.relation.name) << '.' unless collector.value.start_with?('DELETE FROM ') || collector.value.include?(' UPDATE ')
-        collector << quote_column_name(o.name)
+        if collector.value.is_a?(String)
+          collector << quote_table_name(o.relation.table_alias || o.relation.name) << '.' unless collector.value.start_with?('DELETE FROM ') || collector.value.include?(' UPDATE ')
+          collector << quote_column_name(o.name)
+        else
+          super
+        end
       end
 
       def visit_Arel_Nodes_SelectOptions(o, collector)

diff --git a/spec/single/model_spec.rb b/spec/single/model_spec.rb
@@ -107,6 +107,14 @@ class ModelPk < ActiveRecord::Base
       end
     end
 
+    describe '#find_by' do
+      let!(:record) { Model.create!(id: 1, event_name: 'some event') }
+
+      it 'finds the record' do
+        expect(Model.find_by(id: 1, event_name: 'some event')).to eq(record)
+      end
+    end
+
     describe '#reverse_order!' do
       it 'blank' do
         expect(Model.all.reverse_order!.map(&:event_name)).to eq([])