support window named functions

lib/active_record/connection_adapters/clickhouse/quoting.rb

@@ -6,11 +6,11 @@ module Quoting
 
         module ClassMethods # :nodoc:
           def quote_column_name(name)
-            name
+            name.to_s.include?('.') ? "`#{name}`" : name.to_s
           end
 
           def quote_table_name(name)
-            name
+            name.to_s
           end
         end
       end

lib/active_record/connection_adapters/clickhouse/schema_statements.rb

@@ -124,6 +124,10 @@ def schema_migration
           def migration_context
             pool.migration_context
           end
+
+          def internal_metadata
+            pool.internal_metadata
+          end
         end
 
         def assume_migrated_upto_version(version, migrations_paths = nil)

lib/active_record/connection_adapters/clickhouse_adapter.rb

@@ -47,7 +47,7 @@ def is_view
 
   module ModelSchema
     module ClassMethods
-      delegate :final, :final!, :settings, :settings!, to: :all
+      delegate :final, :final!, :settings, :settings!, :window, :window!, to: :all
 
       def is_view
         @is_view || false

lib/arel/visitors/clickhouse.rb

@@ -74,6 +74,14 @@ def visit_Arel_Nodes_DoesNotMatch(o, collector)
         infix_value o, collector, op
       end
 
+      def visit_Arel_Nodes_Rows(o, collector)
+        if o.expr.is_a?(String)
+          collector << "ROWS #{o.expr}"
+        else
+          super
+        end
+      end
+
       def sanitize_as_setting_value(value)
         if value == :default
           'DEFAULT'

lib/clickhouse-activerecord/version.rb

@@ -1,3 +1,3 @@
 module ClickhouseActiverecord
-  VERSION = '1.1.1'
+  VERSION = '1.1.2'
 end

lib/core_extensions/active_record/relation.rb

@@ -64,6 +64,23 @@ def using!(*opts)
         self
       end
 
+      # Windows functions let you perform calculations across a set of rows that are related to the current row. For example:
+      #
+      #   users = User.window('x', order: 'date', partition: 'name', rows: 'UNBOUNDED PRECEDING').select('sum(value) OVER x')
+      #   # SELECT sum(value) OVER x FROM users WINDOW x AS (PARTITION BY name ORDER BY date ROWS UNBOUNDED PRECEDING)
+      #
+      # @param [String] name
+      # @param [Hash] opts
+      def window(name, **opts)
+        spawn.window!(name, **opts)
+      end
+
+      def window!(name, **opts)
+        @values[:windows] = [] unless @values[:windows]
+        @values[:windows] << [name, opts]
+        self
+      end
+
       private
 
       def check_command(cmd)
@@ -80,6 +97,7 @@ def build_arel(connection_or_aliases = nil, aliases = nil)
         arel.final! if @values[:final].present?
         arel.settings(@values[:settings]) if @values[:settings].present?
         arel.using(@values[:using]) if @values[:using].present?
+        arel.windows(@values[:windows]) if @values[:windows].present?
 
         arel
       end

lib/core_extensions/arel/select_manager.rb

@@ -13,6 +13,18 @@ def settings(values)
         self
       end
 
+      # @param [Array] windows
+      def windows(windows)
+        @ctx.windows = windows.map do |name, opts|
+          # https://github.com/rails/rails/blob/main/activerecord/test/cases/arel/select_manager_test.rb#L790
+          window = ::Arel::Nodes::NamedWindow.new(name)
+          opts.each do |key, value|
+            window.send(key, value)
+          end
+          window
+        end
+      end
+
       def using(*exprs)
         @ctx.source.right.last.right = ::Arel::Nodes::Using.new(::Arel.sql(exprs.join(',')))
         self

spec/single/migration_spec.rb

@@ -9,7 +9,7 @@
     end
     let(:directory) { raise 'NotImplemented' }
     let(:migrations_dir) { File.join(FIXTURES_PATH, 'migrations', directory) }
-    let(:migration_context) { ActiveRecord::MigrationContext.new(migrations_dir) }
+    let(:migration_context) { ActiveRecord::MigrationContext.new(migrations_dir, model.connection.schema_migration, model.connection.internal_metadata) }
 
     connection_config = ActiveRecord::Base.connection_db_config.configuration_hash
 

spec/single/model_spec.rb

@@ -230,6 +230,18 @@ class ModelPk < ActiveRecord::Base
       end
     end
 
+    describe '#window' do
+      it 'works' do
+        sql = Model.window('x', order: 'date', partition: 'name', rows: 'UNBOUNDED PRECEDING').select('sum(event_value) OVER x').to_sql
+        expect(sql).to eq('SELECT sum(event_value) OVER x FROM sample WINDOW x AS (PARTITION BY name ORDER BY date ROWS UNBOUNDED PRECEDING)')
+      end
+
+      it 'empty' do
+        sql = Model.window('x').select('sum(event_value) OVER x').to_sql
+        expect(sql).to eq('SELECT sum(event_value) OVER x FROM sample WINDOW x AS ()')
+      end
+    end
+
     describe 'arel predicates' do
       describe '#matches' do
         it 'uses ilike for case insensitive matches' do

spec/spec_helper.rb

@@ -56,16 +56,7 @@ def schema(model)
 end
 
 def clear_db
-  cluster = ActiveRecord::Base.connection_db_config.configuration_hash[:cluster_name]
-  pattern = if cluster
-              normalized_cluster_name = cluster.start_with?('{') ? "'#{cluster}'" : cluster
-
-              "DROP TABLE %s ON CLUSTER #{normalized_cluster_name} SYNC"
-            else
-              'DROP TABLE %s'
-            end
-
-  ActiveRecord::Base.connection.tables.each { |table| ActiveRecord::Base.connection.execute(pattern % table) }
+  ActiveRecord::Base.connection.tables.each { |table| ActiveRecord::Base.connection.drop_table(table, sync: true) }
 rescue ActiveRecord::NoDatabaseError
   # Ignored
 end