Track Cargo.lock and update dependencies
#66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The library was failing to build for users who just cloned the package, this is because without a `Cargo.lock`, cargo would use the most up to date dependencies, which actually failed to compile because of depenedencies issues with WASM. This fixes the `Cargo.toml` to work with the most recent `cargo update` and also tracks a `Cargo.lock` to avoid these kinds of issues in the future.
panleone
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The library was failing to build for users who just cloned the package, this is because without a
Cargo.lock, cargo would use the most up to date dependencies, which actually failed to compile because of depenedencies issues with WASM. This fixes theCargo.tomlto work with the most recentcargo updateand also tracks aCargo.lockto avoid these kinds of issues in the future.