Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability for MPW to run explorer-less #427
base: master
Are you sure you want to change the base?
Add ability for MPW to run explorer-less #427
Changes from 6 commits
5e00057
734fe8f
4687cf0
a607539
cfb691d
b7c526b
5f6e35f
5803780
26aa132
6b4faf8
845555c
4711083
18ecfac
11bcdbd
a266dbd
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 2 in scripts/network.js
GitHub Actions / Run linters
Check warning on line 14 in scripts/network.js
GitHub Actions / Run linters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is very good, we should consider removing the explorer based getBlock
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like using nodes as a fallback for light RPC calls like
getBestBlockHash
,sendTransaction
andgetBlockCount
: the code is more ugly and imo we should just make sure to have working explorersThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Imo we would need at least 2x (4) explorers to consider it a stable network, or we start relying more on Nodes instead, it is the only compromise to get MPW more stable.
Check warning on line 12 in scripts/wallet.js
GitHub Actions / Run linters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is more serious:
getLatestTxs
failed, wallet is almost unusable, balance is wrong and any attempt to create a tx will likely fail.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shield is fully usable and transactable, as well as Masternode controller and Governance. Meanwhile current MPW will not even open/load if explorers are down (which they are down far too frequently).
The idea of the warning anyway is that as soon as the
getLatestTxs
API is available again - we want to re-rungetLatestTxs
and then we can drop the warning (just not sure where to handle this state yet).