Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AsyncInterval class #423

Merged
merged 7 commits into from
Oct 14, 2024
Merged

Add AsyncInterval class #423

merged 7 commits into from
Oct 14, 2024

Conversation

panleone
Copy link
Member

Abstract

setInterval(cb, timeOut) will just call the corresponding callback cb each timeOut seconds, without awaiting for cb to finish. This PR fixes the issue by introducing a class `AsyncInterval'.

@panleone panleone added the Bug This is either a bugfix (PR) or a bug (issue). label Oct 11, 2024
@panleone panleone self-assigned this Oct 11, 2024
Copy link

netlify bot commented Oct 11, 2024

Deploy Preview for cheery-moxie-4f1121 ready!

Name Link
🔨 Latest commit 915b6a6
🔍 Latest deploy log https://app.netlify.com/sites/cheery-moxie-4f1121/deploys/670cc15b775793000867fbdb
😎 Deploy Preview https://deploy-preview-423--cheery-moxie-4f1121.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@Duddino Duddino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests need updating, it used to be that tests didn't catch the missing #shield error because of the setInterval.

scripts/async_interval.js Outdated Show resolved Hide resolved
scripts/wallet.js Outdated Show resolved Hide resolved
Copy link
Member

@Duddino Duddino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@Duddino Duddino merged commit 09c6aff into PIVX-Labs:master Oct 14, 2024
5 checks passed
@panleone panleone deleted the asyncInterval branch October 17, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This is either a bugfix (PR) or a bug (issue).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants