Add CSV exports & massively improve scaling #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JSKitty
requested review from
Liquid369,
Duddino,
PalmTreeVI,
BreadJS and
a team
PalmTreeVI
previously approved these changes
Jul 31, 2023
Liquid369
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract
This is the first of a handful of likely PRs to improve PIVX Promos, using feedback from the release of v1.0
This PR focuses on the scalability of MPW's PIVX Promos implementation, massively improving it's usage in larger scopes, such as mass-generated codes or organised and automated CSV sheet exports.
Promo codes are now stored in Memory rather than only on Disk, persisting their state between 'update ticks', which allows us to render Promos prior to their state being synced (shown as 'Syncing') and also allows multithreaded synchronisation of the codes, handled by the browser.
What does this PR address?
PIVX Promos in MPW could previously slow down a lot under heavy generation, this is resolved by this PR, this also resolves the issue of users having to manually export each code individually: they may now use a CSV sheet to export the entire PIVX Promos list in one click, with an easy-to-read, informative format on each code and their live balances.
What features or improvements were added?
A CSV export for PIVX Promos, alongside massive scaling improvements that lessen loading times and enhances the app's responsiveness.
How does this benefit users?
Faster loading, less waiting, and less manual work by having to export codes by-hand, PIVX Promos can now be partially automated.