forked from JSKitty/scc-web3
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update translation tags, add Portuguese + Brazilian #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Duddino
previously approved these changes
Jul 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK, I did go through MPW and it seemed to be properly translated
Now good for review, final PT-PT and i18n frameworking finished. |
This is easy to check/verify, since it is the Portuguese translaton file with minor edits for the Brazilian variant, run a git-diff between the files to see.
JSKitty
changed the title
Update translation tags, add Portuguese template
Update translation tags, add Portuguese + Brazilian
Jul 30, 2023
BreadJS
approved these changes
Jul 31, 2023
This PR will bypass Branch Protection in order to keep MPW moving at necessary pace. I take responsibility if something breaks. 😉 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract
This PR updates the majority of the app UI (HTML) with i18n translation tags, to catch-up from the ever-growing i18n tech-debt of UI PRs missing i18n data tags, additionally, this PR should prevent services like Google Translate from translating the MPW Seed Phrase; which can lead to loss of funds, and luckily was reported by our Portuguese ambassador.
i18n-data
tags added, removed and updated. (but not ALL).notranslate
tags to Seed Phrase to prevent translating them for anyone using Google Translate.This PR is aimed to quickly catch-up on the majority of i18n tagging and template backlog, but NOT to fully translate any soon-to-change UI elements - especially given the Masternodes page is likely to change given #143 and other Redesigns over there.