-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New 'Governance' page #145
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK f91f1ab
Looks great on Mac this time!! Safari no issues.
Codewise ACK
Compared data between pivx.org and MPW and everything is proper
I tested proposal creation on test net a-ok
Do not have a node to test voting success at the moment but GG
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK f91f1ab
Looking pretty much awesome.
UI is outstanding with tons of new data and functionality.
Tested on both desktop and mobile environment, both tests were pretty smooth and 100% mobile friendly.
I also compared data between the (PIVX Treasury Dashboard), everything looks accurate to me, and you'll find all Governance data you'd ever need.
I couldn't test voting success because this functionality is not available in TestNet. But I pretty much think it's good to go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the overall appearance, godo job. I have a couple of issues though.
I noticed flipdown.js
was included directly instead of using the npm package, is there a specific reason for this?
Also, you can't finalize proposals in this PR (The button is gone)
The timer doesn't work on testnet and it stays the same when you switch network
Co-authored-by: Duddino <duddino@duddino.com>
There's minor CSS conflicts to resolve here, along with JSDoc typing. (for |
Requests resolved:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK. The only issue remaining is that of including flipdown.js
in MPW which I'm not a fan of. Maybe we can fork the library and add module support ourselves, but I would leave it for another PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK bf8d44e
🎉 Beautiful UI, extremely nice features and design - I'm also happy that we finally clarified the finalisation process, as it's always been pretty unclear and awkward with UX.
I have tested this fairly thoroughly on Testnet, with no issues or nits.
In the future, we should redesign the Proposal Creation menu (as the current one is basically a glorified Prompt popup), but that is out of scope for this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK bf8d44e
These improvements are great, the finalization works well, and is noticeable when setting up a new proposal. Vast improvement gg
Abstract
I've changed the design of the 'Governance' page to make it more responsive and have a cleaner UI.
What does this PR address?
MPW was not really responsive for other devices and lacks a good design (IMO). My intent is to redesign MPW for a better look and also make it as responsive as possible for every device.
What features or improvements were added?
Governance
pageMonthly Budget
Budget Allocated
Next Treasury Payout
How does this benefit users?
A better design will lure more users in using MPW. This also applies for making the site more responsive.
PIVX Address
DDS5v6mPqUN3rdzkp3268LV7TKjHCZqy8c