-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PMID:27819043 The hijacking of a receptor kinase-driven pathway by a wheat fungal pathogen leads to disease. #91
Comments
I suspected this would happen once we tested the system on community curators. The simplest fix I can think of is to add individual annotation extensions for each part of the compound terms, even though that removes the efficiency benefit of the original solution. Individual extensions might not be suitable if the options need to depend on each other (as suggested above). Implementing the feature any other way is going to be a lot of work and will need careful discussion.
We maybe want to be careful that we don't make the list of options longer than the metagenotype rows, but really these rows should be using a pop-up list (like the Genotype Management page) instead of having the list always visible. If we can fix that then we can add an arbitrary number of curation types (albeit at the cost of some redundancy in the configuration). On the other hand if the annotation extension list is broken up into multiple fields, this might be less of a problem.
There was some discussion of this problem at pombase/canto#2339 (comment), but the issue was closed before deciding on any solutions. |
@CuzickA Which annotation extensions were you expecting to be disabled? We may just need to tweak the cardinality settings. |
We could explore adding an intro page or some extra guidance for first-time curators. If the introduction was tied to a curation session being started, then we probably wouldn't need to set browser cookies to keep track of things. I definitely think we should hide the feature for admin curators. Hiding the feature for community curators who are starting a second new curation session could be a bit tricky, but maybe if Canto could do this by tracking the first time a curator email or ORCID was used. |
We could look at embedding video clips or animated GIFs into the documentation if we think that the effort is justified. It would take quite a bit of work, and it wouldn't really work with the current documentation setup, because all our documentation is stored in the pombase/canto repository (once it's published anyway; before then it's stored in PHI-base/docs). We definitely don't want to add video clips or animated GIFs to the repository itself, because most version control software (particularly Git) really isn't designed for that. If we had somewhere external that we could store this media (maybe just as simple as a folder on the Canto server), and we could link to the files in the documentation, then it would be feasible. |
|
I'm guessing that in PHI-Canto's case, the initial pathogen-host interaction annotation is done using the standard workflow, then curators use that annotation as a template for subsequent interactions that are created using Copy and edit. Presumably this is because the burden of our annotation extensions is higher than it is for PomBase. If that's the method Alayne uses, then it's likely to be passed on to community curators during initial training. So maybe the usability issues of the Copy and edit pop-up will be more noticeable with PHI-base. |
I'm guessing that in PHI-Canto's case, the initial pathogen-host
interaction annotation is done using the standard workflow, then
curators use that annotation as a template for subsequent interactions
that are created using Copy and edit. Presumably this is because the
burden of our annotation extensions is higher than it is for PomBase.
If that's the method Alayne uses, then it's likely to be passed on to
community curators during initial training. So maybe the usability
issues of the Copy and edit pop-up will be more noticeable with PHI-base.
I suspect it is the same for PomBase, but I was asked by Kim and Midori
to confirm which workflow people are using. I *hope* most people use
copy edit, but I'm speculating.....
|
Chris made a couple more annotations on his own, I read through the paper and made a couple of edits/ new annotations. We met again this morning to talk through the annotations we have. A few further points of note
It would be good to have examples of these 'tricky' alleles in the help doc or videos.
|
For now I think we've decided to try and prevent this from happening in the first place with extra curator guidance (ideally at the first screen of the step-based curation interface), but I'm not sure that will be sufficient, especially since including help text in the step-based workflow won't help curators that prefer the pop-up-based workflow. It might not be so bad to add this feature if it was admin-only, but making it available to all users will need some careful thought about how to handle creating invalid annotations. Different annotation types can have different ontology namespaces, and even those in the same ontology namespace can have different annotation extensions. The transfer feature will either have to clear these incompatible properties or prompt the curator to change them. |
Hi @ValWood do you think these 'physical interaction ' annotations should be deleted in favour of keeping the PHI phenotype annotations below? |
I would keep one "physical interaction annotation" to show that the interaction exists and they expect it occurs in vivo. Make the comment more explicitly that these constructs were made to get around some membrane issue. |
and keep both of the PHIPO term annotations? |
Actually i'm not sure about those. There is presence and loss of binding but it is more in the realm of a control, and not representing what is thought to occur in vivo. I would be inclined not to capture these differences as phenotypes in this particular case. We really use the phenotype loss of binding to establish when mutants create a "functionally relevant loss of binding". |
can discuss tomorrow? |
I have now added the new (inverse) GfG AE terms to this session to cover the pathogen Necrotophic Effectors and host Susc locus. (Note: still a few typos to resolve in these new PHIPO_EXT terms). I will apply these new (inverse) GfG AE terms to the other relevant session #22 It is possible that this will leave some 'unused' GfG terms that can then be obsoleted to keep the number of choices down. It may also be worth considering have two options for the AE in the GfG work flow @ValWood I would still like to discuss the 'RNA level' and 'Protein interaction' annotations with you. Discussed 29Jan 2021, notes above and session updated |
Just waiting for a NTR from PHI-ECO then session is complete and ready for approval |
Added new PHI-ECO term Session now approved |
Trial curation of this paper into main PHI-Canto tool by Chris Stephens (final year PhD student)
https://canto.phi-base.org/curs/6ddeb3a009b5a0e5
We talked through the curation of Fig 2B and 2D and did this together online. Chris will work though some more annotations and we will meet again in a couple of days.
Feedback
1) Gene-for-gene interaction annotation extension
(05_02_2021 new AE inverse GfG now used in session)
2) Editing annotation extensions
3) Overall curation workflow
4) Training materials
5) Initial curation email
FYI @ValWood @jseager7
The text was updated successfully, but these errors were encountered: