GS/HW: Maintain scale on subsequent downscale draws #12344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I checked Dragon Quest VIII, Prince of Persia The Sands of Time and Valkyrie Profile 2, no regressions found |
|
Thanks for testing :) Yeah so far it seems to be net-positive, shadows are generally softer in some cases as they should be, the Ratchet DoF is more correct, stuff like that. And it fixes a problem with normal scaling in Onimusha 3, which isn't really noticable until RT in RT |
JordanTheToaster
approved these changes
Feb 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
maintains already downscaled targets on more downscaling.
Rationale behind Changes
it was doing partial draws downscaled then upscaling it immediately in Onimusha 3 when using Normal NS, which is wrong.
Suggested Testing Steps
test games which use native scaling, make sure they don't look more gross.
Changes which are technically better or different:
BBoy:
Master:
PR:
Spyro:
Master:
PR:
Ratchet & Clank Up Your Arsenal:
Master:
PR:
Tomb Raider Legends:
Master:
PR:
