Memcard: Apply filtering when checking all possible memcard options #12343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents log being flooded with warnings when large folder memcards exceed 8 MB size
refractionpcsx2
approved these changes
Feb 22, 2025
Mrlinkwii
approved these changes
Feb 22, 2025
JordanTheToaster
approved these changes
Feb 23, 2025
kamfretoz
approved these changes
Feb 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
This function is only called when the UI needs to know how many memcards you have for display purposes, but to do so needs to at least open them to see what they are. Switched enableFiltering from forced false to use whatever the automatically manage checkbox is set to.
Rationale behind Changes
Prevents log being flooded with warnings when large folder memcards exceed 8 MB size and trying to open settings or run GS dumps.
Suggested Testing Steps
Have a folder memcard containing more than 8 MB of data. Enable the log window. Open your settings menu. Verify that, if in your memory card settings the checkbox for automatically managing is ticked, you are no longer getting warnings for the folder memcard being full. Close PCSX2 and repeat for loading a GS dump.