Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GameDB: Memory card filters for TOCA Race Driver 3 and NFS games #12340

Merged
merged 6 commits into from
Feb 24, 2025
Merged

GameDB: Memory card filters for TOCA Race Driver 3 and NFS games #12340

merged 6 commits into from
Feb 24, 2025
+397 −22

Conversation

CookiePLMonster
Copy link
Contributor

@CookiePLMonster CookiePLMonster commented Feb 22, 2025 •
edited
Loading

Please merge together with PCSX2/pcsx2_patches#499.

Description of Changes

Multiple NFS games and TOCA Race Driver 3 grant bonuses if they detect saves from the previous game in the series. This was previously set only for NFS Most Wanted (looking for saves from Underground 2), but even that was not exhaustive.

In this PR:

  • Filters for Most Wanted have been improved.
  • Filters for Carbon have been added. One of the checks in Carbon has a bug and checks for a wrong serial of MW Black Edition. Both wrong and correct serials have been added to the database, and a patch to correct the serial has been submitted to the patch repo. Filters for Underground 2 were also added, as the game has unused code referencing those.
  • Filters for ProStreet have been added. Filters for Underground 2 were also added, as the game has unused code referencing those.
  • Undercover copypastes the save scanning code from Carbon and leaves it unused, so I mirrored Carbon filters for that game too.
  • Filters for TOCA Race Driver 3 looking for Race Driver 2 have been added (+ typo fix).

image

Rationale behind Changes

Making stock game functionality work properly.

Suggested Testing Steps

Test starting new careers in:

  • NFS Most Wanted
  • NFS Carbon
  • NFS ProStreet
  • TOCA Race Driver 3

when you have saves from the previous games in your folder memcard.

NOTE: I was only able to test filters from the NTSC-U NFS games, the rest goes untested but based on the US binary files!

@CookiePLMonster CookiePLMonster mentioned this pull request Feb 22, 2025
Merged
@CookiePLMonster CookiePLMonster marked this pull request as draft February 22, 2025 17:33
@CookiePLMonster
Copy link
Contributor Author

Updated PAL definitions of Carbon and Undercover as I found out those do not try to list SLAJ-25075 for Most Wanted BE, instead they have no serial for that release at all.

@CookiePLMonster CookiePLMonster marked this pull request as ready for review February 22, 2025 18:39
@CookiePLMonster
Copy link
Contributor Author

Updated with better filters for SLES-55006, accounting for the fact this SKU tries to poll for NTSC-U Most Wanted.

F0bes
F0bes reviewed Feb 24, 2025
View reviewed changes
Copy link
Member

@F0bes F0bes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this ready?

@CookiePLMonster
Copy link
Contributor Author

Yes, I tested all SKUs I could. As for others, not sure if more testing was done.

@F0bes F0bes merged commit 29b736b into PCSX2:master Feb 24, 2025
13 checks passed
F0bes pushed a commit to PCSX2/pcsx2_patches that referenced this pull request Feb 24, 2025
@CookiePLMonster
NFS Carbon/ProStreet: Correct the serial the game uses to detect Most…
7c2d5cb 
… Wanted Black Edition saves (#499)

**Please merge together with
PCSX2/pcsx2#12340

Fixes an old bug where only base Most Wanted saves granted the cash
bonus, and MW Black Edition saves did not. This is because the game used
an incorrect serial to detect BE saves.


![image](https://github.com/user-attachments/assets/d1bbaaba-c283-4518-8af6-6e139dc24460)

ProStreet is seemingly unaffected, as it detects Most Wanted, Most
Wanted BE, Carbon, Carbon CE correctly.
@CookiePLMonster CookiePLMonster deleted the nfs-filter-fixes branch February 24, 2025 17:40
Hancock33 added a commit to Hancock33/batocera.piboy that referenced this pull request Feb 26, 2025
@Hancock33
Updates on Feb 24, 2025 18:46
64fa111 
---------------------------------------------------------
libxmp.mk libxmp-4.6.2 # Version: Commits on Feb 24, 2025
---------------------------------------------------------
Checksums (SHA256):

```

acac1705be2c4fb4d2d70dc05759853ba6aab747a83de576b082784d46f5a4b9  libxmp-4.6.2.tar.gz

f4d03ea076c4beecd1c834d07cf7adadb6e680ae45dcc9cf8aff279c4748d003  libxmp-lite-4.6.2.tar.gz

```

Changes in version 4.6.2 (20250224):

- Fix MED effect 1Fxy (delay and retrigger). The new implementation

  supports both delay and retrigger at the same time and repeats.

- Fix MED effect FF3 (revert change from 4.6.1). The buggy version

  of this effect prior to OctaMED v5 is not currently supported.

- Fix MED3 and MED4 time factor and tempos 1-10.

- Fix MED4 effect 9xx (set speed).

- Add support for MED3 and MED4 song files.

- Better MED MMD tracker version fingerprinting.

- Fix loading external instruments from the current directory.

- Fix oxm modules with empty samples (e.g.: The Four Ages.oxm)

- Fix some modules would be misidentified as Scream Tracker 2.

- Handle IT modules with edit history but no midi configuration

- Revert a bad CVE fix to the miniz inflate code

- Add missing HAVE_DIRENT definition to Android makefile.

------------------------------------------------------------------------------------------
dolphin-emu.mk 6dd0793f1b8f2e84f2713d8d159d4b6187e4daae # Version: Commits on Feb 24, 2025
------------------------------------------------------------------------------------------
Translation resources sync with Transifex,

---------------------------------------------------------------------------------------------
dosbox-staging.mk fb9ffd6780ed45fbbed4ab8b82fc8d26b47d66ee # Version: Commits on Feb 22, 2025
---------------------------------------------------------------------------------------------
website: Add 0.82.1 release notes draft,

------------------------------------------------------------------------------------------
duckstation.mk fbbc4943f675603d009c3c7359977fce909104d2 # Version: Commits on Feb 24, 2025
------------------------------------------------------------------------------------------
FullscreenUI: Fix crash in game properties on non-scanned file,

----------------------------------------------------
pcsx2.mk v2.3.174 # Version: Commits on Feb 24, 2025
----------------------------------------------------
- [GameDB: Memory card filters for TOCA Race Driver 3 and NFS games](PCSX2/pcsx2#12340)

,

-------------------------------------------------------------------------------------
ppsspp.mk d1ea78fbe7231038e54d2ea9cc4c3a88c5dd7866 # Version: Commits on Feb 24, 2025
-------------------------------------------------------------------------------------
Merge pull request #20023 from hrydgard/misc-fixes

Add confirmation popup support on Exit App key, libretro buildfix,

------------------------------------------------------------------------------------
rpcs3.mk 4794558c08dc931a079537a5b2a47cfff43e0818 # Version: Commits on Feb 24, 2025
------------------------------------------------------------------------------------
Fix Azure and Github Actions CI caching,

---------------------------------------------------------------
ruffle.mk nightly-2025-02-24 # Version: Commits on Feb 24, 2025
---------------------------------------------------------------
## What's Changed

* core: Do not panic on missing parent in text variable binding by @kjarosh in ruffle-rs/ruffle#19597

* avm2: Set correct version to Socket::timeout by @adrian17 in ruffle-rs/ruffle#19610

**Full Changelog**: ruffle-rs/ruffle@nightly-2025-02-23...nightly-2025-02-24,

--------------------------------------------------------------------------------------
shadps4.mk fd3bfdae807ee747d55b655717331475dea5679a # Version: Commits on Feb 24, 2025
--------------------------------------------------------------------------------------
Implement some RDNA flags (#2510),

---------------------------------------------------------------------------------------------
solarus-engine.mk 7e4342498cf9890cbad6d106360439fcc8662470 # Version: Commits on Feb 24, 2025
---------------------------------------------------------------------------------------------
Merge branch 'hhromic/openal-findmodule' into 'dev'

---------------------------------------------------------------------------------------
thextech.mk 244e068404902d57adbfe750206195b6e67822c3 # Version: Commits on Feb 24, 2025
---------------------------------------------------------------------------------------
Test XMessage status before rendering,

--------------------------------------------------------------------------------------
tsugaru.mk 8d6b4ce5aa657e053a645bccdf483ff7ba1d9397 # Version: Commits on Feb 24, 2025
--------------------------------------------------------------------------------------
Hope I am handling close-button correctly in macOS.,

-------------------------------------------------
vice.mk r45506 # Version: Commits on Feb 24, 2025
-------------------------------------------------
XDG desktop files: handle make's DESTDIR to allow for staged installs

Update the calls to `desktop-file-install` to pass $DESTDIR as its `--dir`

argument so installing into a staging directory as a non-root user will place

the .desktop files into their proper location. The installation of icon files

with `xdg-icon-resource` into a staging directory will require some equivalent

logic to be applied (working on that).

Also add dashes in front of the calls to `update-desktop-database` to have

`make` ignore the failure of said program when not running as root.

See bug #2127.

git-svn-id: https://svn.code.sf.net/p/vice-emu/code/trunk@45506 379a1393-f5fb-40a0-bcee-ef074d9b53f7,

------------------------------------------------------------------------------------------
devilutionx.mk ad18ebc671310f5b0e277a723cba4ba0a92a85ce # Version: Commits on Feb 24, 2025
------------------------------------------------------------------------------------------
Update Italian localization (close #7783) (#7784),

----------------------------------------------------------------------------------
stk.mk 9030521c8cae3970cff369e2aaac5df075238905 # Version: Commits on Feb 24, 2025
----------------------------------------------------------------------------------
Fix PCSS Bugs,

---------------------------------------------------------------------------------------------
theforceengine.mk 671cdc85021b5fc53e819406d9ec378c79087ef6 # Version: Commits on Feb 23, 2025
---------------------------------------------------------------------------------------------
More flag cleanup (removed ull, etc. since they are 32-bit now).,

----------------------------------------------------------------------------------------------------
sdl2-gamecontrollerdb.mk dfb332addb981e1ae434e431978a9cc2b47637b0 # Version: Commits on Feb 23, 2025
----------------------------------------------------------------------------------------------------
GeekyFab adapter analogue triggers

thanks LeftyPem,

---------------------------------------------------------------------------------------------
easyrpg-player.mk ab5df15cd4b663891135dd3836b763961e81b1d7 # Version: Commits on Feb 24, 2025
---------------------------------------------------------------------------------------------
Merge pull request #3356 from Ghabry/android-screenfix

Android: Properly handle rotations,

----------------------------------------------------------------------------------------
retroarch.mk c413bcc626ec2e4bc343e82e5d62a8b4190d220c # Version: Commits on Feb 24, 2025
----------------------------------------------------------------------------------------
Threaded emscripten fixes (#17614)

* Actually read CLI args in emscripten

* Fix fetchfs manifest parsing, increase download chunk size

The chunk size should probably be made a parameter in the future.  The

larger chunk size trades longer hitches for fewer hitches.

* Add exec command driver and API functions for emscripten.

Under WASMFS, stdin/stdout can't be customized the way they can with

the JS FS implementation.  Also, this approach frees up stdin/stdout

and simplifies interaction with the command interface for web embedders.

* fixup upload paths, show use of new emscripten cmd interface

* Add JS library function names to EXPORTS as well as EXPORTED_FUNCTIONS for older emsdk versions,

-----------------------------------------------------------------------------------------
libdmdutil.mk a729cd0149b3cf3bd04c854cccba4580b357b3e5 # Version: Commits on Feb 24, 2025
-----------------------------------------------------------------------------------------
deps: simplify SHAs. update libzedmd (#64),

---------------------------------------------------------------------------------------------
vulkan-samples.mk aaccd0ccd3fa8753d0c0764c76e56f3e53671a8c # Version: Commits on Feb 24, 2025
---------------------------------------------------------------------------------------------
Replace CLI11 by a simple command line argument handling. (#1274),

----------------------------------------------------------------------------------------
doomretro.mk 5b52b9ac38766ec70ec83bbf14a19b0dc7e5f3fd # Version: Commits on Feb 24, 2025
----------------------------------------------------------------------------------------
Update releasenotes.md,

-----------------------------------------------------------------------------------------
sonic3-air.mk 7510078ef3c32f841496bd0f0b0e5f075a2848f1 # Version: Commits on Feb 23, 2025
-----------------------------------------------------------------------------------------
Added a simple dev mode window for viewing an overview of persistent data entries,

------------------------------------------------------------------------------------------
xash3d-fwgs.mk 74ad504377a64e5b1c100a3463766b019a87f22f # Version: Commits on Feb 24, 2025
------------------------------------------------------------------------------------------
engine: client: console: do not let color strings contribute to line length in console,

-----------------------------------------------------------------------------------------------
libretro-easyrpg.mk ab5df15cd4b663891135dd3836b763961e81b1d7 # Version: Commits on Feb 24, 2025
-----------------------------------------------------------------------------------------------
Merge pull request #3356 from Ghabry/android-screenfix

Android: Properly handle rotations,

---------------------------------------------------------------------------------------------
libretro-fbneo.mk df655a14e3b8ec450216fe7d71edfd2aded3a090 # Version: Commits on Feb 24, 2025
---------------------------------------------------------------------------------------------
(libretro) fix for finalburnneo/FBNeo#1958,

--------------------------------------------------------------------------------------------
libretro-mgba.mk 5fd0ba0d6725d6e0f9da2a3ff86b4c28fb085bc1 # Version: Commits on Feb 24, 2025
--------------------------------------------------------------------------------------------
GBA Cheats: Let VBA-style codes patch ROM (fixes #3423),

----------------------------------------------------------------------------------------------
libretro-ppsspp.mk d1ea78fbe7231038e54d2ea9cc4c3a88c5dd7866 # Version: Commits on Feb 24, 2025
----------------------------------------------------------------------------------------------
Merge pull request #20023 from hrydgard/misc-fixes

Add confirmation popup support on Exit App key, libretro buildfix,
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@F0bes F0bes F0bes left review comments

@Mrlinkwii Mrlinkwii Mrlinkwii approved these changes

Assignees
No one assigned
Labels
GameDB
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CookiePLMonster @Mrlinkwii @F0bes