Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Add debug UI options for new GS dumping options. #12302

Merged
merged 2 commits into from
Feb 24, 2025

Conversation

TJnotJT
Copy link
Contributor

@TJnotJT TJnotJT commented Feb 13, 2025

Description of Changes

Add UI elements for options to control dumping of GS data in the System/Settings/Debug/GS menu. Specifically: SaveInfo, SaveAlpha, Start Frame Number, Frame Dump Count. Note: This is a quick (but hopefully not dirty) PR to add the missing functionality that I intend to improve in a followup PR.

Rationale behind Changes

I forgot to add these in a previous PR that added the said options.

Suggested Testing Steps

Run any game and use the options mentioned above in the menubar System/Settings/Debug/GS (after enabling advanced settings in the menubar Tools/Show Advanced Settings).

Copy link
Contributor

@lightningterror lightningterror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HW and SW dump directories seem inverted?

When Dump GS Draws is unchecked all other options should grey out.

Draw dumping seems inconsistent, sometimes they dump, sometimes not.
For me it seems to only dump if you switch between renderers.

@F0bes
Copy link
Member

F0bes commented Feb 16, 2025

Couldn't reproduce any inconsistency. Was just about to mention the other things.

@TJnotJT
Copy link
Contributor Author

TJnotJT commented Feb 17, 2025

Thanks for points out the issues @lightningterror and @F0bes. Fixed the HW/SW directories being swapped and the expected graying out when we disable Dump GS Data.

I could not reproduce the inconsistency either. One gotcha that may cause the issue is that the intersection of draw number range and frames number range is used, so if they do not overlap, then nothing will be dumped.

@lightningterror
Copy link
Contributor

These were the settings I used
image

@TJnotJT
Copy link
Contributor Author

TJnotJT commented Feb 17, 2025

@lightningterror I think there is a good chance that wouldn't dump anything because the frame number and draw number both start from 0, so as long as the 0th frame took 21 or more draws nothing would be dumped. Would it be better for the UI to expect draw/frame numbers to be 0-based?

@F0bes
Copy link
Member

F0bes commented Feb 22, 2025

I think it being 0 based is fine.

@TJnotJT
Copy link
Contributor Author

TJnotJT commented Feb 22, 2025

@F0bes Ok, I'll leave it as is then

Copy link
Member

@F0bes F0bes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Rebased locally and verified that this will not cause conflicts with #11461

@F0bes F0bes merged commit 23a28be into PCSX2:master Feb 24, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants