fix integer pow for Julia 1.8

PALEOtoolkit · Sep 19, 2022 · 3954f38 · 3954f38 · sjdaines · Sep 19, 2022
1 parent 1833e73
commit 3954f38
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 7 deletions.
diff --git a/.gitignore b/.gitignore
@@ -0,0 +1 @@
+Manifest.toml
diff --git a/Project.toml b/Project.toml
@@ -1,7 +1,7 @@
 name = "SparsityTracing"
 uuid = "06eadbd4-12ad-4cbc-ab6e-10f8370940a5"
 authors = ["Stuart Daines <stuart.daines@gmail.com>"]
-version = "0.2.4"
+version = "0.2.5"
 
 [deps]
 DiffRules = "b552c78f-8df3-52c6-915a-8e097449b14b"

diff --git a/src/SparsityTracing.jl b/src/SparsityTracing.jl
@@ -353,12 +353,7 @@ gen_logical_rules()
 # TODO fixups #
 ###############
 # Errors Base.:^(d::ADval{T}, n::Integer) is ambiguous ? 
-# adding literal_pow apparently fixes this but might not be the right fix
-Base.literal_pow(::typeof(^), d::ADval{T}, ::Val{0}) where {T} = one(d)
-Base.literal_pow(::typeof(^), d::ADval{T}, ::Val{1}) where {T} = d
-Base.literal_pow(::typeof(^), d::ADval{T}, ::Val{2}) where {T} = d*d
-Base.literal_pow(::typeof(^), d::ADval{T}, ::Val{3}) where {T} = d*d*d
-Base.literal_pow(::typeof(^), d::ADval{T}, ::Val{4}) where {T} = d*d*d*d
 
+Base.:^(d::ADval{T}, p::Integer) where {T} = d^Float64(p)
 
 end