Impove webpack bundler #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes sure the bundle/script that is generated by webpack exposes
UMAPproperly on the global object. Previously, the bundler created multiple exports that were unusual. The need for thelibraryproperty is also documented in the webpack documentation: https://webpack.js.org/configuration/output/#librarytarget-umdI've also added the globalObject configuration and followed the recommendation here: https://webpack.js.org/configuration/output/#outputglobalobject
With these changes, the created script looks much more like a regular bundled script and works well in our environment.