DataTable: Change reactImmediately to react to eliminate console warn…

…ing. PiperOrigin-RevId: 555592557
PAIR-code · Aug 11, 2023 · 20d8caa · 20d8caa
1 parent d25392b
commit 20d8caa
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 7 deletions.
diff --git a/lit_nlp/client/modules/data_table_module.ts b/lit_nlp/client/modules/data_table_module.ts
@@ -396,12 +396,11 @@ export class DataTableModule extends LitModule {
     });
   }
 
-  override firstUpdated() {
+  override connectedCallback() {
+    super.connectedCallback();
     const updateColsChange = () =>
-        [this.appState.currentModels, this.appState.currentDataset, this.keys];
-    this.reactImmediately(updateColsChange, () => {
-      this.updateColumns();
-    });
+      [this.appState.currentModels, this.appState.currentDataset, this.keys];
+    this.react(updateColsChange, () => {this.updateColumns();});
   }
 
   private updateColumns() {

diff --git a/lit_nlp/client/modules/scalar_module.ts b/lit_nlp/client/modules/scalar_module.ts
@@ -141,7 +141,7 @@ export class ScalarModule extends LitModule {
   }
 
   override firstUpdated() {
-    this.reactImmediately(
+    this.react(
         () => this.classificationService.allMarginSettings,
         () => {
           for (const [id, {model, key, xScale}] of this.plots.entries()) {
@@ -169,7 +169,7 @@ export class ScalarModule extends LitModule {
       // the DataService instead.
       this.dataService.dataVals
     ];
-    this.reactImmediately(getDataChanges, () => {
+    this.react(getDataChanges, () => {
       for (const info of this.plots.values()) {
         info.points?.clear();
         delete info.points;