Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add features to participant preview #252

Merged
merged 23 commits into from
Sep 27, 2024
Merged

Add features to participant preview #252

merged 23 commits into from
Sep 27, 2024

Conversation

vivtsai
Copy link
Collaborator

@vivtsai vivtsai commented Sep 26, 2024 •
edited
Loading

  • Fix layout bugs for stage views
  • Add imageId fields to survey (multiple choice), chat (discussion thread), election stages and use Firebase storage to retrieve images
    • NOTE: This currently means manually loading frontend/assets images to the storage emulator. Filed #254 to create a script to help populate and #255 to create a frontend gallery so users can directly upload/select images
  • Add fields to base stage (and use in rendering waiting, progress components):
    • waitForAllParticipants: boolean - wait until all non-obsolete participants have unlocked stage
    • minParticipants: number - wait until minParticipants (0 by default) have unlocked stage
    • showParticipantsCompleted: boolean - if true, render progress_stage_completed component in footer
  • Hardcode WTL logic for election/ranking
  • Add ready to end chat discussion progress view
  • Update info/help icons to use custom modal

@vivtsai vivtsai self-assigned this Sep 26, 2024
This was linked to issues Sep 26, 2024
padding at bottom of survey actually just fix content div—padding should be one layer in #239
Closed
Add participants completed status in footer #242
Closed
@vivtsai vivtsai marked this pull request as ready for review September 26, 2024 07:52
@vivtsai vivtsai marked this pull request as draft September 26, 2024 07:52
@vivtsai vivtsai requested a review from cjqian September 26, 2024 07:53
@vivtsai vivtsai linked an issue Sep 26, 2024 that may be closed by this pull request
Only show "right/wrong" icon in reveal if the multiple choice item has a correct answer #251
Closed
@vivtsai
Update padding for all participant stage previews
419e3d7
@vivtsai
Add component for participant stage completion progress
c4a533d
@vivtsai
Fix layout for Terms of Service timestamp
83c6e56
@vivtsai
Use Firebase storage for images
7a868b4 
Note that this currently requires adding image assets to Firebase
storage, including the Firebase storage emulator. Will open a feature
request for adding a script to populate the storage emulator.
@vivtsai
Fix payout rendering bug when participant answer is missing
0ca3ff6
@vivtsai
Add imageId field to multiple choice items to use in survey rendering
485778d 
Instead of hardcoding based on LAS game, use the new imageId field
(try rendering image if field is not empty).
@vivtsai
Add imageId field to chat discussion item to use in chat rendering
1a8d0ed 
Instead of hardcoding based on LAS game, use the new imageId field.
@vivtsai
Add progress config to base stage and use in waiting screen logic
e60ac44 
Show waiting screen if the current stage has not reached min
participants, or if waitForParticipants is set to true and some
participants have not yet unlocked the stage.
@vivtsai
Allow stage description rendering in profile stage
2fa63f1
@vivtsai
Render progress-stage-completed if showParticipantProgress is true fo…
bb6e5ae 
…r stage
@vivtsai
Don't show waiting screen if experimenter (otherwise stage preview is…
a3c35db 
… blocked)
@vivtsai
Only render right/wrong icon in survey reveal if question has a corre…
7d3a8c8 
…ct answer
@vivtsai
Fix bug in field name
1c5e08e
@vivtsai
Add utils function to create new election item and fix missing field bug
981c6a7
@vivtsai
Fix election formatting bugs
00f3b77
@vivtsai
Fix indentation, typo, and gift card item id/description in gift card…
bb7b72f 
… game
@vivtsai vivtsai linked an issue Sep 26, 2024 that may be closed by this pull request
For synchronous stages (chat, election), don't allow participants to move forward until N participants have hit the stage (add this stage parameter, and remove it from experiment parameters) #233
Closed
@vivtsai vivtsai mentioned this pull request Sep 26, 2024
Closed
@vivtsai vivtsai linked an issue Sep 26, 2024 that may be closed by this pull request
Chat history disappears if chat stage is not current stage (i.e., before/after chat stage) #268
Closed
@cjqian
Copy link
Member

cjqian commented Sep 27, 2024

LGTM. Is it expected that images don't render locally?

@cjqian cjqian marked this pull request as ready for review September 27, 2024 01:20
@vivtsai
Copy link
Collaborator Author

vivtsai commented Sep 27, 2024 •
edited
Loading

Is it expected that images don't render locally?

Yes, but you can load them into the emulator—see PR description:

NOTE: This currently means manually loading frontend/assets images to the storage emulator. Filed #254 to create a script to help populate and #255 to create a frontend gallery so users can directly upload/select images

@vivtsai vivtsai linked an issue Sep 27, 2024 that may be closed by this pull request
Make info icon easier to read #260
Closed
@vivtsai vivtsai merged commit 0c82a1a into main Sep 27, 2024
1 check passed
@vivtsai vivtsai deleted the preview branch September 27, 2024 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjqian cjqian cjqian approved these changes

Assignees

@vivtsai vivtsai

Labels
None yet
Projects
None yet
Milestone
✅ 6 - Deployment at Scale Milestone
2 participants
@vivtsai @cjqian