Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make info icon easier to read #260

Closed
cjqian opened this issue Sep 26, 2024 · 1 comment · Fixed by #252
Closed

Make info icon easier to read #260

cjqian opened this issue Sep 26, 2024 · 1 comment · Fixed by #252
Labels
enhancement
Milestone
✅ 6 - Deployment ...

Comments

@cjqian
Copy link
Member

cjqian commented Sep 26, 2024

Image
@cjqian cjqian added the bug Something isn't working label Sep 26, 2024
@vivtsai
Copy link
Collaborator

vivtsai commented Sep 26, 2024

Let's do this for "help" icon too! (Maybe similar to what you had in the original - sorry that I didn't have time to bring that over.)

We'll also want a max height (maybe calc(100vh - common.$header-height * 2)?) with overflow auto.

@vivtsai vivtsai added duplicate This issue or pull request already exists feature New feature or request enhancement and removed bug Something isn't working duplicate This issue or pull request already exists feature New feature or request labels Sep 26, 2024
cjqian added a commit that referenced this issue Sep 27, 2024
@cjqian
Fix info and help modals.
40cadef 
#260
@vivtsai vivtsai linked a pull request Sep 27, 2024 that will close this issue
Add features to participant preview #252
Merged
@vivtsai vivtsai closed this as completed Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
✅ 6 - Deployment at Scale Milestone
Development

Successfully merging a pull request may close this issue.

Add features to participant preview PAIR-code/deliberate-lab
2 participants
@cjqian @vivtsai