Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For synchronous stages (chat, election), don't allow participants to move forward until N participants have hit the stage (add this stage parameter, and remove it from experiment parameters) #233

Closed
cjqian opened this issue Sep 24, 2024 · 1 comment · Fixed by #252

Comments

@cjqian
Copy link
Member

cjqian commented Sep 24, 2024

No description provided.

@vivtsai
Copy link
Collaborator

vivtsai commented Sep 26, 2024

We now have minParticipants, which prevents everyone from starting (not completing) the stage if min participants is not reached. Is that acceptable?

I think it's okay to keep the experimenter param one—that prevents people from clicking "Start experiment" (which is before any of the stages). We might never use it but it's not actually redundant

@vivtsai vivtsai linked a pull request Sep 26, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants