Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROU-11034: Fixed error in console when clicking a cell on autogenerated Grids #432

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

gnbm
Copy link
Collaborator

@gnbm gnbm commented Aug 26, 2024

This PR is to fix an error in the console when clicking a cell on autogenerated Grids using JSON Serialize.

What was happening

  • Error in the console when clicking a cell on autogenerated Grids using JSON Serialize.
    image

What was done

  • In the method _raiseCellClickEvent created a fallback using the binding instead of getting the column that is undefined in this scenario.

Test Steps

  1. Go to a screen containing an autogenerated Grid using JSON Serialize.
  2. Click any cell with the dev tools console opened
  3. Checked that no error is thrown

Checklist

  • tested locally
  • documented the code
  • clean all warnings and errors of eslint
  • requires changes in OutSystems (if so, provide a module with changes)
  • requires new sample page in OutSystems (if so, provide a module with changes)

@gnbm gnbm added the bug Something isn't working label Aug 26, 2024
Copy link

@gnbm gnbm marked this pull request as ready for review August 26, 2024 14:00
@gnbm gnbm requested a review from a team as a code owner August 26, 2024 14:00
@gnbm gnbm merged commit cd000fb into dev Aug 27, 2024
13 checks passed
@gnbm gnbm deleted the ROU-11034 branch August 27, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants