Not working using TCP

[cmanzur]

Prerequisites

• Put an X between the brackets on this line if you have done all of the following:
  • Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3AOutOfSyncStudios
  • Reproduced the behavior multiple times

Description

I'm using the same example at the readme. It works with UDP. Using UDP it hangs.

Steps to Reproduce

1. Run logstash with the same configuration at the official README.md

input {
  tcp {
    codec => json
    port => 28777
  }
}

2. Run nodejs using the same example BUT using TCP:

const Winston = require('winston');
const WinstonLogStash = require('winston3-logstash-transport');

const logger = Winston.createLogger();

logger.add(new WinstonLogStash({
  mode: 'tcp',
  host: '127.0.0.1',
  port: 28777
}));

logger.error('Some Error');

Expected behavior:

The log must appear in elasticsearch and the node process must end.

Actual behavior:

The node process never ends. The log doesn't appear in ES.
The process hangs. If I manually finalize the process using ctrl+C, then it stops and the log appears in ES.

Reproduces how often:

Always

Versions

• Docker docker.elastic.co/logstash/logstash-oss:7.10.2
• Docker nodejs:14.15.4-alpine3.10
• Dependencies:
  -- winston 3.3.3
  -- winston3-logstash-transport 1.2.3

Additional Information

If I run logstash using UDP and winston using mode: 'udp' it works. But I want TCP mode.

[LuanaMartelli]

Hello,

This issue may be quite old, but I ran into the same problem.
Looking at the code and thanks to this answer on Stackoverflow, I change the line 133 in file index.js to
this.socket.write(message + '\n', undefined, callback);
and this fixed the problem for TCP.

Hope it helps for further uses.
Cheers.

[fauzanelka]

Rather than directly modifying the library. For now, you could actually use the option trailingLineFeed to true.