GraphQL Orderby not working

[zyr2288]

I set createdUtc to DESC, but the sorting is not correct.

query MyQuery {
  article(orderBy: {createdUtc: DESC}) {
    displayText
    createdUtc
  }
}

{
  "data": {
    "article": [
      {
        "displayText": "First",
        "createdUtc": "2025-02-11T04:51:32.6114111Z"
      },
      {
        "displayText": "Second",
        "createdUtc": "2025-02-11T04:51:41.4293335Z"
      }
    ]
  }
}

In the source

    private static IQuery<ContentItem, ContentItemIndex> OrderBy(IQuery<ContentItem, ContentItemIndex> query,
        IResolveFieldContext context)
    {
        if (context.HasPopulatedArgument("orderBy"))
        {
            var orderByArguments = JObject.FromObject(context.Arguments["orderBy"].Value);

            if (orderByArguments != null)
            {
                var thenBy = false;

                foreach (var property in orderByArguments)
                {
                    // Maybe there's something wrong with this line in the source code
                    // property.Value -> Descending
                    // direction -> Ascending
                    var direction = (OrderByDirection)property.Value.Value<int>();

                    Expression<Func<ContentItemIndex, object>> selector = null;

                    switch (property.Key)
                    {
                        case "contentItemId": selector = x => x.ContentItemId; break;
                        case "contentItemVersionId": selector = x => x.ContentItemVersionId; break;
                        case "displayText": selector = x => x.DisplayText; break;
                        case "published": selector = x => x.Published; break;
                        case "latest": selector = x => x.Latest; break;
                        case "createdUtc": selector = x => x.CreatedUtc; break;
                        case "modifiedUtc": selector = x => x.ModifiedUtc; break;
                        case "publishedUtc": selector = x => x.PublishedUtc; break;
                        case "owner": selector = x => x.Owner; break;
                        case "author": selector = x => x.Author; break;
                    }

                    if (selector != null)
                    {
                        if (!thenBy)
                        {
                            query = direction == OrderByDirection.Ascending
                                    ? query.OrderBy(selector)
                                    : query.OrderByDescending(selector)
                                ;
                        }
                        else
                        {
                            query = direction == OrderByDirection.Ascending
                                    ? query.ThenBy(selector)
                                    : query.ThenByDescending(selector)
                                ;
                        }

                        thenBy = true;
                    }
                }
            }
        }
        else
        {
            query = query.OrderByDescending(x => x.CreatedUtc);
        }

        return query;
    }

[github-actions]

Thank you for submitting your first issue, awesome! 🚀 We're thrilled to receive your input. If you haven't completed the template yet, please take a moment to do so. This ensures that we fully understand your feature request or bug report. On what happens next, see the docs.

If you like Orchard Core, please star our repo and join our community channels.

[zyr2288]

Wouldn't it be better to change it to something like this?

var direction = Enum.Parse<OrderByDirection>(property.Value.Value<string>());

[gvkries]

You're absolutely right, nice finding. I've seen this error too, but forgot about it. I guess this happened due to updating to STJ.