Update Defender deployments to use Defender SDK #894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: @openzeppelin/platform-deploy-client@0.10.0 |
ernestognw
approved these changes
Oct 12, 2023
Comment on lines
39
to
40
| "@openzeppelin/defender-admin-client": "^1.48.0", | ||
| "@openzeppelin/defender-base-client": "^1.48.0", |
There was a problem hiding this comment.
Are we still actively using these? I see even proposals are included in the new SDK but don't know about the status what are the Defender libraries we kept.
There was a problem hiding this comment.
These are used for Defender v1 and are not deprecated yet, so we can keep them for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #888