Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validations for namespaced storage layout #876

Merged
merged 135 commits into from
Sep 27, 2023
Merged

Add validations for namespaced storage layout #876

merged 135 commits into from
Sep 27, 2023

Conversation

ericglau
Copy link
Member

@ericglau ericglau commented Sep 7, 2023 •
edited
Loading

Adds upgrade safety validations for implementations that use ERC-7201: Namespaced Storage Layout.

@socket-security
Copy link

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
solidity-ast 0.4.52 None +41 4.11 MB frangio

frangio
frangio reviewed Sep 26, 2023
View reviewed changes
Copy link
Contributor

@frangio frangio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry these are my final comments. All relatively minor I think.

packages/core/CHANGELOG.md Outdated Show resolved Hide resolved
packages/core/src/storage/extract.ts Outdated Show resolved Hide resolved
packages/core/src/storage/extract.ts Outdated Show resolved Hide resolved
packages/core/src/storage/extract.ts Show resolved Hide resolved
packages/core/src/utils/make-namespaced.ts Outdated Show resolved Hide resolved
packages/core/src/storage/namespace.ts Show resolved Hide resolved
packages/core/src/storage/namespace.ts Outdated Show resolved Hide resolved
packages/core/src/storage/namespace.ts Show resolved Hide resolved
packages/core/src/storage/namespace.ts Outdated Show resolved Hide resolved
packages/core/src/storage/namespace.ts Outdated Show resolved Hide resolved
ericglau and others added 19 commits September 26, 2023 10:18
@ericglau @frangio
Update packages/core/CHANGELOG.md
b3fced1 
Co-authored-by: Francisco <fg@frang.io>
@ericglau @frangio
Update packages/core/src/utils/make-namespaced.ts
cfc11b0 
Co-authored-by: Francisco <fg@frang.io>
@ericglau @frangio
Update packages/core/src/storage/namespace.ts
6918047 
Co-authored-by: Francisco <fg@frang.io>
@ericglau @frangio
Update packages/core/src/utils/make-namespaced.ts
b8848c1 
Co-authored-by: Francisco <fg@frang.io>
@ericglau @frangio
Update packages/core/src/storage/extract.ts
646c334 
Co-authored-by: Francisco <fg@frang.io>
@ericglau
Lint and update comment
d80c85e
@ericglau @frangio
Update packages/core/src/storage/namespace.ts
f88c233 
Co-authored-by: Francisco <fg@frang.io>
@ericglau
Assert isStructMembers
bde851a
@ericglau
Use assert/strict
76ba26e
@ericglau @frangio
Update packages/core/src/utils/make-namespaced.ts
68bd53e 
Co-authored-by: Francisco <fg@frang.io>
@ericglau
Add comment for loadLayoutType
9e131ec
@ericglau
Simplify check for duplicate namespaces
3405182
@ericglau
Rename var
f461e5f
@ericglau
Remove variable
bd3fa30
@ericglau
Remove variable
10df6e6
@ericglau
Simplify GotTypeMembers
c521097
@ericglau @frangio
Update packages/core/src/utils/make-namespaced.ts
14ef3df 
Co-authored-by: Francisco <fg@frang.io>
@ericglau @frangio
Update packages/core/src/storage/namespace.ts
e58d73c 
Co-authored-by: Francisco <fg@frang.io>
@ericglau
Lint
c712b4c
@ericglau ericglau requested a review from frangio September 26, 2023 21:11
frangio
frangio approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@frangio frangio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LFG!

@ericglau ericglau merged commit 754f203 into OpenZeppelin:master Sep 27, 2023
9 checks passed
@ericglau ericglau deleted the namespaced branch September 27, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frangio frangio frangio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ericglau @frangio