-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support TypeChain in deployProxy function #535
Support TypeChain in deployProxy function #535
Conversation
@frangio please let me know your thoughts on this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @frimoldi! This looks solid. I'd love to have a test for this but our tests in this package are written in JavaScript so I don't think we can set one up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay. I realized we also have to cover the other functions like upgradeProxy
, deployBeaconProxy
, etc. Do you want to take a look at those?
@frangio sure, I'll take a look as soon as I can. |
@frimoldi Let us know if you can carry on with this. 🙂 |
@frangio Yes. Sorry for the delay, I'll find some time this week. |
Would love this |
Any update on this? |
@frimoldi Hey! How it's going ?) |
What's the status of this? |
Thanks for the initial work and discussions here. This was completed in #1099 and is available in @openzeppelin/hardhat-upgrades@3.8.0 |
As discussed in #325, this change allows
deployProxy
to returned a typedContract
instance, so the user can use things like Typechain without loosing contract's types definition.Usage example in a hardhat script 👇🏽