-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI: Support --exclude
option
#1065
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a very small suggestion. Looks good to me.
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@nomicfoundation/hardhat-verify@2.0.9), npm/@openzeppelin/contracts-upgradeable@5.0.2), npm/@openzeppelin/defender-sdk-base-client@1.14.3), npm/@openzeppelin/defender-sdk-deploy-client@1.14.3), npm/@openzeppelin/defender-sdk-network-client@1.14.3), npm/@openzeppelin/upgrades-core@1.36.0) |
Adds an
--exclude "<GLOB_PATTERN>" [--exclude "<GLOB_PATTERN>"...]
option to the CLI, which allows glob patterns of source file paths that should be excluded from the validation report. If passing in multiple patterns, call the option multiple times, once for each pattern.This supports any of the user's source files or their dependencies. Note this only supports file paths (e.g. the paths of
.sol
files), not the names of specific contracts in those files.Additional notes:
--contract <CONTRACT_NAME>
option was specified and the file is excluded via the--exclude
option, an error will be thrown.**/contracts/proxy/beacon/UpgradeableBeacon.sol
is always added to theexclude
list automatically, sinceUpgradeableBeacon
contains anupgradeTo(address)
function and is incorrectly detected as an implementation contract.--referenceBuildInfoDirs
and--unsafeAllow
options to support those options being called either with a comma (as before) or multiple times (introduced in this PR).--exclude
does not treat comma as a delimiter, because globs can have commas within them e.g.--exclude "**/{A,B}.sol"
Fixes #1035
Fixes #849