Apply review comments - simplify

OpenZeppelin · Dec 17, 2024 · d7385c1 · d7385c1
1 parent 4a4ea90
commit d7385c1
Showing 1 changed file with 1 addition and 6 deletions.
diff --git a/packages/core/src/validate/run.ts b/packages/core/src/validate/run.ts
@@ -681,7 +681,7 @@ function* getInitializerErrors(
       baseContractDefs.map(base => [base.name, getPossibleInitializers(base, true)]),
     );
     const baseContractsWithInitializers = baseContractDefs
-      .filter(base => hasInitializers(base.name, baseContractsInitializersMap))
+      .filter(base => baseContractsInitializersMap.get(base.name)?.length)
       .map(base => base.name);
 
     if (baseContractsWithInitializers.length > 0) {
@@ -768,11 +768,6 @@ function* getInitializerErrors(
   }
 }
 
-function hasInitializers(baseName: string, baseContractsInitializersMap: Map<string, FunctionDefinition[]>) {
-  const initializers = baseContractsInitializersMap.get(baseName);
-  return initializers !== undefined && initializers.length > 0;
-}
-
 function getPossibleInitializers(contractDef: ContractDefinition, isParentContract: boolean) {
   const fns = [...findAll('FunctionDefinition', contractDef)];
   return fns.filter(