catch verification error

OpenZeppelin · Oct 13, 2023 · 9607408 · 9607408
1 parent 50bee37
commit 9607408
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 8 deletions.
diff --git a/packages/plugin-hardhat/src/utils/deploy-impl.ts b/packages/plugin-hardhat/src/utils/deploy-impl.ts
@@ -11,6 +11,7 @@ import {
 } from '@openzeppelin/upgrades-core';
 import type { ContractFactory, ethers } from 'ethers';
 import type { EthereumProvider, HardhatRuntimeEnvironment } from 'hardhat/types';
+import { runVerify } from '../verify-proxy';
 import { deploy } from './deploy';
 import { GetTxResponse, DefenderDeployOptions, StandaloneOptions, UpgradeOptions, withDefaults } from './options';
 import { getRemoteDeployment } from '../defender/utils';
@@ -141,10 +142,7 @@ async function deployImpl(
     }
   }
 
-  await hre.run('verify:verify', {
-    address: deployment.address,
-    constructorArguments: opts.constructorArgs ?? [],
-  });
+  await runVerify(hre, deployment.address, opts.constructorArgs);
 
   return { impl: deployment.address, txResponse };
 }
diff --git a/packages/plugin-hardhat/src/utils/deploy.ts b/packages/plugin-hardhat/src/utils/deploy.ts
@@ -2,6 +2,7 @@ import type { Deployment, RemoteDeploymentId } from '@openzeppelin/upgrades-core
 import type { ethers, ContractFactory, ContractMethodArgs } from 'ethers';
 import { HardhatRuntimeEnvironment } from 'hardhat/types';
 import { defenderDeploy } from '../defender/deploy';
+import { runVerify } from '../verify-proxy';
 import { EthersDeployOptions, DefenderDeployOptions, UpgradeOptions } from './options';
 
 export interface DeployTransaction {
@@ -27,10 +28,7 @@ export async function deploy(
     response = await ethersDeploy(factory, ...args);
   }
 
-  await hre.run('verify:verify', {
-    address: response.address,
-    constructorArguments: opts.constructorArgs ?? [],
-  });
+  await runVerify(hre, response.address, opts.constructorArgs);
 
   return response;
 }

diff --git a/packages/plugin-hardhat/src/verify-proxy.ts b/packages/plugin-hardhat/src/verify-proxy.ts
@@ -1,3 +1,4 @@
+import { TASK_VERIFY_VERIFY } from '@nomicfoundation/hardhat-verify/internal/task-names';
 import {
   getTransactionByHash,
   getImplementationAddress,
@@ -11,6 +12,7 @@ import {
   isEmptySlot,
 } from '@openzeppelin/upgrades-core';
 import artifactsBuildInfo from '@openzeppelin/upgrades-core/artifacts/build-info.json';
+import { HARDHAT_NETWORK_NAME } from 'hardhat/plugins';
 
 import { HardhatRuntimeEnvironment, RunSuperFunction } from 'hardhat/types';
 
@@ -61,6 +63,17 @@ const verifiableContracts = {
   proxyAdmin: { artifact: ProxyAdmin, event: 'OwnershipTransferred(address,address)' },
 };
 
+export async function runVerify(hre: HardhatRuntimeEnvironment, address: string, constructorArguments: unknown[] = []) {
+  try {
+    await hre.run(TASK_VERIFY_VERIFY, {
+      address,
+      constructorArguments,
+    });
+  } catch (e) {
+    // fail silently
+  }
+}
+
 /**
  * Overrides hardhat-verify's verify:etherscan subtask to fully verify a proxy or beacon.
  *