Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add gamedata as lua modules root. #1610

Merged
merged 1 commit into from
Dec 27, 2024

Conversation

Neloreck
Copy link
Contributor

@Neloreck Neloreck commented Feb 14, 2024

Changes

  • Adding string script to use $game_data$ as lua modules root
  • Allows usage of multiple files with custom game scripts using built-in lua tools without globals/patched GSC interceptors

Limitations

  • Lua does not check DB files so scripts called with require should be under gamedata/* root
  • Approach with monkeypatching does not work with locals/requires, but it is great for usage with tools like https://github.com/TypeScriptToLua/TypeScriptToLua

@Xottab-DUTY Xottab-DUTY added Enhancement Lua Modmaker Experience Modmaker experience with OpenXRay labels Feb 15, 2024
@Xottab-DUTY Xottab-DUTY force-pushed the dev branch 2 times, most recently from 5b2ec76 to 6fffce9 Compare May 4, 2024 03:27
@Xottab-DUTY Xottab-DUTY force-pushed the dev branch 2 times, most recently from e89fcc8 to f6fd5cc Compare October 24, 2024 02:36
@Xottab-DUTY Xottab-DUTY merged commit 6adea8e into OpenXRay:dev Dec 27, 2024
26 of 31 checks passed
@Neloreck Neloreck deleted the dev-lua-require branch December 27, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Lua Modmaker Experience Modmaker experience with OpenXRay
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants