Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dataloading Country History - Part 2 #87

Merged
merged 2 commits into from
Dec 10, 2023
Merged

Dataloading Country History - Part 2 #87

merged 2 commits into from
Dec 10, 2023

Conversation

zaaarf
Copy link
Member

@zaaarf zaaarf commented Dec 9, 2023

Added:

  • Technology loading
  • TechnologySchool loading
  • Invention loading
  • Foreign investment loading
  • A bunch of other keys that were missing, it only seemed to work because we had success_callback as default

@zaaarf zaaarf self-assigned this Dec 9, 2023
@zaaarf zaaarf added the enhancement New feature or request label Dec 9, 2023
Hop311
Hop311 reviewed Dec 9, 2023
View reviewed changes
Copy link
Contributor

@Hop311 Hop311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, the history loading code is perfect, thanks for going beyond tech & inventions to finish loading most of the rest of the file's contents 👍

src/openvic-simulation/history/CountryHistory.hpp Outdated Show resolved Hide resolved
src/openvic-simulation/history/CountryHistory.cpp Outdated Show resolved Hide resolved
src/openvic-simulation/history/CountryHistory.cpp Outdated Show resolved Hide resolved
src/openvic-simulation/history/CountryHistory.hpp Outdated Show resolved Hide resolved
@zaaarf zaaarf force-pushed the dataloading-country-history-2 branch from ade68db to 125b782 Compare December 10, 2023 00:21
@zaaarf zaaarf force-pushed the dataloading-country-history-2 branch from 125b782 to 2c562ac Compare December 10, 2023 00:38
Hop311
Hop311 approved these changes Dec 10, 2023
View reviewed changes
Copy link
Contributor

@Hop311 Hop311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another great PR, thank you

@zaaarf zaaarf merged commit b3d0af9 into master Dec 10, 2023
12 checks passed
@zaaarf zaaarf deleted the dataloading-country-history-2 branch December 10, 2023 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hop311 Hop311 Hop311 approved these changes

Assignees

@zaaarf zaaarf

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zaaarf @Hop311