Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Victoria 2 path searching to Vic2PathSearch.cpp #84

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

Spartan322
Copy link
Member

Move fshash and _cached_paths definitions to Dataloader::Search_for_game_path

@Spartan322 Spartan322 added the enhancement New feature or request label Dec 4, 2023
@Spartan322 Spartan322 requested a review from Hop311 December 4, 2023 18:11
Move fshash and _cached_paths definitions to Dataloader::Search_for_game_path
@Spartan322 Spartan322 force-pushed the move/vic2-path-search branch from 79a2cfc to 7019dcc Compare December 4, 2023 19:54
Copy link
Contributor

@Hop311 Hop311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you 👍

@Spartan322
Copy link
Member Author

Will wait until the latest commit is fixed before merging.

@Spartan322 Spartan322 merged commit db00dcf into master Dec 5, 2023
@Spartan322 Spartan322 deleted the move/vic2-path-search branch December 5, 2023 15:47
Hop311 pushed a commit to Hop311/OpenVic-Simulation that referenced this pull request Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants