-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more unit tests #293
Merged
Merged
Add more unit tests #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
be8aaac
to
390e105
Compare
a3a44b4
to
b3321fb
Compare
9a1a1db
to
a7898ca
Compare
wvpm
reviewed
Feb 7, 2025
wvpm
reviewed
Feb 7, 2025
wvpm
previously approved these changes
Feb 7, 2025
d4d2120
to
ac282bb
Compare
Hop311
previously approved these changes
Feb 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work!
Add Fixed Point unit tests Add Vector unit tests Add Colour unit tests Add Date unit tests Add Timespan unit tests Add Approx to assist floating point comparisons Separate unit test build and run options Add double Vector (for testing) Add Vector <=>, >, >=, <, <= operators Add Vector cross-type operators Add `fixed_point_t::_0_25()` Add Fixed Point float comparison operators Make fixed_point_t(int64) constructor explicit Fix fixed_point_t Vector abs function Add rgb and rgba integer parsing to Colour Add Colour string parse methods Add invert operator to Colour Add full_invert to Colour (includes alpha) Add _rgba Colour user-defined literal Add Timespan prefix and postfix -- operators Add Timespan to_chars method Add Date prefix and postfix -- operators Add Date to_chars method Improve Date to_string method Add Date from_chars method Improve Date from_string method Add Date from_string_log method
ac282bb
to
4a936e5
Compare
Hop311
approved these changes
Feb 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, congrats on being the one to resolve our longstanding lack of unit testing! 🎉🎉🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Fixed Point unit tests
Add Vector unit tests
Add Colour unit tests
Add Date unit tests
Add Timespan unit tests
Add Approx to assist floating point comparisons
Separate unit test build and run options
Add double Vector (for testing)
Add Vector <=>, >, >=, <, <= operators
Add Vector cross-type operators
Add
fixed_point_t::_0_25()
Add Fixed Point float comparison operators
Make fixed_point_t(int64) constructor explicit
Fix fixed_point_t Vector abs function
Add rgb and rgba integer parsing to Colour
Add Colour string parse methods
Add invert operator to Colour
Add full_invert to Colour (includes alpha)
Add _rgba Colour user-defined literal
Add Timespan prefix and postfix -- operators
Add Timespan to_chars method
Add Date prefix and postfix -- operators
Add Date to_chars method
Improve Date to_string method
Add Date from_chars method
Improve Date from_string method
Add Date from_string_log method