Fix use-after-free when using custom ntp server #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also fixes issue #264
Tested on my OpenSprinkler 3
Issue:
OpenSprinkler likes to periodically lookup gibberish DNS names when a custom NTP server has been configured. This lookup is often correlated with lookups of time.google.com and time.nist.gov, and the configured NTP server stops being queried when this starts to happen. Exact issue presentation can vary based on how some of the other settings are configured.
Cause:
It seems that configTime() requires its strings to be accessible after the function call is finished.
Fix:
Allocate a static buffer for the NTP server IP address string.