-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove cookiecutter #149
Merged
Merged
Remove cookiecutter #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #149 +/- ##
============================================
+ Coverage 58.49% 100.00% +41.50%
============================================
Files 3 10 +7
Lines 159 141 -18
============================================
+ Hits 93 141 +48
+ Misses 66 0 -66 ☔ View full report in Codecov by Sentry. |
This was referenced Jun 27, 2024
This was
linked to
issues
Jul 10, 2024
hmgaudecker
reviewed
Jul 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks a lot! Two things:
- We should add a test to the pipeline that runs pytask (call it
test_template.py
and include it among the list of things to delete right away) - In
docs_template/source/getting_started/customising_the_template.md
, please rearrange and adjust. First step needs to be to search fortemplate_project
in the entire codebase and replace with a valid Python object identifier. Otherwise, everyone will have atemplate_project
environment, which will be confusing to people. And instead of "Review and update the following files...", we should again give precise instructions of what to search for and what to replace that by. I am thinking of a table like this one.
Almost done, thanks!!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What remains to be done in other PRs: