Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cookiecutter #149

Merged
merged 63 commits into from
Jul 15, 2024
Merged

Remove cookiecutter #149

merged 63 commits into from
Jul 15, 2024

Conversation

timmens
Copy link
Member

@timmens timmens commented Jun 22, 2024

  • Remove cookiecutter
  • Merge inner and outer layer of the project
  • Switch to new pytask syntax
  • Use hatch for package building
  • Add Python 3.12 to test matrix
  • Update visualization tasks for docs
  • Update documentation
  • Plot R results in python (read rds file from python)

What remains to be done in other PRs:

  • Update the data management code

Copy link

codecov bot commented Jun 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (eda143b) to head (e75d584).

Additional details and impacted files
@@             Coverage Diff              @@
##             main      #149       +/-   ##
============================================
+ Coverage   58.49%   100.00%   +41.50%     
============================================
  Files           3        10        +7     
  Lines         159       141       -18     
============================================
+ Hits           93       141       +48     
+ Misses         66         0       -66     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@hmgaudecker hmgaudecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks a lot! Two things:

  1. We should add a test to the pipeline that runs pytask (call it test_template.py and include it among the list of things to delete right away)
  2. In docs_template/source/getting_started/customising_the_template.md, please rearrange and adjust. First step needs to be to search for template_project in the entire codebase and replace with a valid Python object identifier. Otherwise, everyone will have a template_project environment, which will be confusing to people. And instead of "Review and update the following files...", we should again give precise instructions of what to search for and what to replace that by. I am thinking of a table like this one.

Almost done, thanks!!!

.github/ISSUE_TEMPLATE/bug_report.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/documentation.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/enhancement.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/question.md Outdated Show resolved Hide resolved
.github/workflows/main.yml Outdated Show resolved Hide resolved
.pre-commit-config.yaml Outdated Show resolved Hide resolved
LICENSE Outdated Show resolved Hide resolved
docs_template/rtd_environment.yml Outdated Show resolved Hide resolved
@hmgaudecker hmgaudecker merged commit be74854 into main Jul 15, 2024
5 checks passed
@hmgaudecker hmgaudecker deleted the remove-cookiecutter branch July 15, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants