Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use git_remote_url throughout instead of a mix with hand-constructed links. #144

Closed
wants to merge 1 commit into from

Conversation

hmgaudecker
Copy link
Member

  • Was using different links in setup.cfg
  • Now git_remote_url everywhere, must have the form https://github.com/<user or organisation name>/<repo name>
  • Add assert statements and tests
  • Explain in dialogue

Copy link

codecov bot commented Dec 19, 2023

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 60.81%. Comparing base (eda143b) to head (1af30db).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
hooks/post_gen_project.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #144      +/-   ##
==========================================
+ Coverage   58.49%   60.81%   +2.32%     
==========================================
  Files           3        3              
  Lines         159      171      +12     
==========================================
+ Hits           93      104      +11     
- Misses         66       67       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hmgaudecker
Copy link
Member Author

Irrelevant with #149

@hmgaudecker hmgaudecker deleted the fix_github_links branch June 27, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant