[ADD] compliance criteria managers for program

[nhatnm0612]

What this PR does?

• Add compliance managers to Programs
• Add a way to create new program with compliance managers
• Add a new button to filter cycles membership by its program compliance managers
• Add a configuration for selecting automated filtering cycles membership / entitlements on cycles

Closed #90
Replace #102

[jeremi]

@CodiumAI-Agent /review

[CodiumAI-Agent]

PR Analysis

• 🎯 Main theme: Adding compliance criteria managers to Programs in OpenSPP
• 📝 PR summary: This PR introduces compliance criteria managers to Programs in OpenSPP. It provides a way to create new programs with compliance managers and a new button to filter cycles membership by its program compliance managers. It also includes a configuration for selecting automated filtering cycles membership/entitlements on cycles.
• 📌 Type of PR: Enhancement
• 🧪 Relevant tests added: Yes
• ⏱️ Estimated effort to review [1-5]: 4, due to the complexity of the changes and the number of files affected.
• 🔒 Security concerns: No security concerns found

PR Feedback

• 💡 General suggestions: The PR seems to be well-structured and follows good practices. It includes relevant tests and handles different edge cases. However, it's recommended to ensure that all the error messages are clear and informative for the end user. Also, consider handling exceptions in a more granular way to provide more specific error messages.

• 🤖 Code feedback:

  • relevant file: spp_programs_compliance_criteria/wizards/g2p_program_create_wizard.py
    suggestion: Consider using a dictionary or a switch-case like structure instead of multiple if-elif statements in the _create_compliance_manager method. This would make the code more readable and maintainable. [medium]
    relevant line: '+ def _create_compliance_manager(self, program):'

  • relevant file: spp_programs_compliance_criteria/models/managers/g2p_program_entitlement_manager_default.py
    suggestion: It's recommended to avoid using magic strings like "2" directly in the code. Consider defining a constant with a meaningful name for this value. [medium]
    relevant line: '+ automated_beneficiaries_filtering_mechanism == "2"'

  • relevant file: spp_programs_compliance_criteria/models/managers/g2p_cycle_manager_default.py
    suggestion: It's recommended to avoid using magic strings like "1" directly in the code. Consider defining a constant with a meaningful name for this value. [medium]
    relevant line: '+ automated_beneficiaries_filtering_mechanism == "1"'

  • relevant file: spp_programs_compliance_criteria/tests/test_g2p_program_create_wizard.py
    suggestion: It's recommended to avoid hardcoding values like "valid" in the tests. Consider defining constants for these values. [medium]
    relevant line: '+ self._test.compliance_sql_query_valid = "valid"'

How to use

Tag me in a comment '@CodiumAI-Agent' and add one of the following commands:
/review [-i]: Request a review of your Pull Request. For an incremental review, which only considers changes since the last review, include the '-i' option.
/describe: Modify the PR title and description based on the contents of the PR.
/improve [--extended]: Suggest improvements to the code in the PR. Extended mode employs several calls, and provides a more thorough feedback.
/ask <QUESTION>: Pose a question about the PR.
/update_changelog: Update the changelog based on the PR's contents.

To edit any configuration parameter from configuration.toml, add --config_path=new_value
For example: /review --pr_reviewer.extra_instructions="focus on the file: ..."
To list the possible configuration parameters, use the /config command.