Skip to content
This repository has been archived by the owner on Mar 28, 2024. It is now read-only.

[ADD]spp programs compliance criteria #102

Closed
wants to merge 6 commits into from
Closed

Conversation

nhatnm0612
Copy link
Contributor

@nhatnm0612 nhatnm0612 commented Jul 12, 2023

What this PR does?

  • Having a setting to select programs's benificiaries should obey all of it eligibility managers or one of them
  • Having a mechanism to filter currently valid benificiaries in program / cycle
  • Having a cron job to pause invalid enrolled benificiaries for each ongoing-cycle-program and all of its ongoing cycles
  • Having automated tests

Close: #90

@nhatnm0612 nhatnm0612 marked this pull request as draft July 12, 2023 16:49
@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Merging #102 (51e318b) into 15.0 (f585380) will increase coverage by 2.19%.
The diff coverage is 98.19%.

@@            Coverage Diff             @@
##             15.0     #102      +/-   ##
==========================================
+ Coverage   80.26%   82.46%   +2.19%     
==========================================
  Files          75       89      +14     
  Lines        1718     1939     +221     
  Branches      185      205      +20     
==========================================
+ Hits         1379     1599     +220     
- Misses        287      289       +2     
+ Partials       52       51       -1     
Files Changed Coverage Δ
spp_programs/models/res_config_settings.py 77.77% <77.77%> (ø)
...ance_criteria/wizards/g2p_program_create_wizard.py 84.61% <84.61%> (ø)
spp_programs/models/__init__.py 100.00% <100.00%> (ø)
spp_programs_compliance_criteria/__init__.py 100.00% <100.00%> (ø)
...pp_programs_compliance_criteria/models/__init__.py 100.00% <100.00%> (ø)
...compliance_criteria/models/g2p_cycle_membership.py 100.00% <100.00%> (ø)
...programs_compliance_criteria/models/g2p_program.py 100.00% <100.00%> (ø)
...mpliance_criteria/models/g2p_program_membership.py 100.00% <100.00%> (ø)
spp_programs_compliance_criteria/tests/__init__.py 100.00% <100.00%> (ø)
spp_programs_compliance_criteria/tests/common.py 100.00% <100.00%> (ø)
... and 5 more

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nhatnm0612 nhatnm0612 changed the title [WIP][ADD]spp programs compliance criteria [ADD]spp programs compliance criteria Jul 14, 2023
@nhatnm0612 nhatnm0612 marked this pull request as ready for review July 14, 2023 08:17
@gonzalesedwin1123 gonzalesedwin1123 changed the base branch from 15.0 to 15.1 August 13, 2023 22:06
@nhatnm0612
Copy link
Contributor Author

Closed to replace by #109

@nhatnm0612 nhatnm0612 closed this Aug 23, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement compliance criteria
1 participant