Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mutual dependency between QvLib and BspLib #53

Open
tribad opened this issue Jul 10, 2018 · 1 comment
Open

Mutual dependency between QvLib and BspLib #53

tribad opened this issue Jul 10, 2018 · 1 comment

Comments

@tribad
Copy link
Contributor

tribad commented Jul 10, 2018

There are a dependency between the QvLib and the BSPLib. Each one is using functions of the other library.
But on a closer look. In QvLib the dependency only is needed in QvTraverse.cpp. I think these Functions should be moved into the BspLib and there into the VrmlFile.cpp

The developers of the QvLib may have thought it was a good idea to let the traversal of the node-tree be part of the specific user of the QvLib. So the user of this lib is the BspLib and so the implementation of these Methods should be done in BspLib.

@tribad
Copy link
Contributor Author

tribad commented Jul 10, 2018

The best would be to make it more classes.
This would allow us to better incorporate more fancy usage to the libraries without touch them all the time. Maybe extending it to VRML2.0 or XSD?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant