-
Notifications
You must be signed in to change notification settings - Fork 496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contribute: zfs driver and zfs driver shared over ISCSI #5654
base: one-6.2
Are you sure you want to change the base?
Conversation
0b269ff
to
b94dad5
Compare
enabled: true | ||
actions: | ||
change_authentication: true | ||
update_password: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.
9e1985e
to
d019bd4
Compare
settings_auth_tab: true | ||
actions: | ||
# Buttons for settings_info_tab | ||
User.update_password: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.
# Buttons for settings_config_tab | ||
Settings.change_language: true | ||
Settings.change_password: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.
settings_auth_tab: true | ||
actions: | ||
# Buttons for settings_info_tab | ||
User.update_password: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.
User.two_factor_auth: true | ||
# Buttons for settings_config_tab | ||
Settings.change_language: true | ||
Settings.change_password: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.
settings_auth_tab: true | ||
actions: | ||
# Buttons for settings_info_tab | ||
User.update_password: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.
settings_showback_tab: true | ||
actions: | ||
# Buttons for settings_info_tab | ||
User.update_password: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.
User.two_factor_auth: true | ||
# Buttons for settings_config_tab | ||
Settings.change_language: true | ||
Settings.change_password: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.
# Buttons for settings_config_tab | ||
Settings.change_language: true | ||
Settings.change_password: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.
User.two_factor_auth: true | ||
# Buttons for settings_config_tab | ||
Settings.change_language: true | ||
Settings.change_password: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.
actions: | ||
User.refresh: true | ||
User.create_dialog: true | ||
User.update_password: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.
settings_auth_tab: true | ||
actions: | ||
# Buttons for settings_info_tab | ||
User.update_password: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.
actions: | ||
User.refresh: true | ||
User.create_dialog: true | ||
User.update_password: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.
actions: | ||
# Buttons for settings_info_tab | ||
User.update_password: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.
User.two_factor_auth: true | ||
# Buttons for settings_config_tab | ||
Settings.change_language: true | ||
Settings.change_password: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.
actions: | ||
User.refresh: true | ||
User.create_dialog: true | ||
User.update_password: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.
actions: | ||
User.refresh: true | ||
User.create_dialog: true | ||
User.update_password: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.
actions: | ||
User.refresh: true | ||
User.create_dialog: true | ||
User.update_password: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.
User.two_factor_auth: true | ||
# Buttons for settings_config_tab | ||
Settings.change_language: true | ||
Settings.change_password: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.
actions: | ||
User.refresh: true | ||
User.create_dialog: true | ||
User.update_password: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.
actions: | ||
# Buttons for settings_info_tab | ||
User.update_password: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.
Signed-off-by: Victor Hansson <vhansson@opennebula.io>
New and very cool Micro-Frontend architecture for Sunstone * Removed devexpress dependencies due to conflicts with @emotion/css * Rewrote chartist component to use recharts instead * Fixed #6788 * Updated packages & shared deps * Adds the ability to dynamically change the URL of a remote without restarting - All modules (remotes) are resolved from the /etc/sunstone/remotes-config.json file * Change to deterministic naming * Enabled parallel builds for components * Adds a minimal fallback editor for when modules fail to load * Client bootstrapping test-loads all remotes, reverting to editor in case it can't be resolved * Server now handles failed parsing of remotes-config.json - Sends a fallback config in such cases pointing all remotes to localhost. Signed-off-by: Victor Hansson <vhansson@opennebula.io>
Signed-off-by: Victor Hansson <vhansson@opennebula.io>
(cherry picked from commit 352b9f0)
* Tab-manifest now supports a 'moduleId' property, allowing you to specify which remote module a component should be loaded from. Imports are restricted to those defined in the remotes-config file. Signed-off-by: Victor Hansson <vhansson@opennebula.io>
This commit add support for the NVIDIA mdev framework intriduce with Ubuntu 24.04 release. The change includes: - Type of mdev is added by a new monitor attribute MDEV_MODE (<'legacy'|'nvidia'>). An empty MDEV_MODE in the PCI device defaults to 'legacy' - Profile monitoring has been also adapted to the new framework. - vgpu has been extended to prepare the vGPU prior to VM boot according to the new framework. - KVM domain generates the PCI device using the type='pci' and managed='no' to accomodate the new mdev interface. Older OS/driver versions will use the legacy interface. (cherry picked from commit 216c329b650a64034220f9fed5e5c5425ea8eabd)
Co-authored-by: Tino Vázquez <cvazquez@opennebula.io>
Ruby's #arity method: "Returns a nonnegative integer for methods that take a fixed number of arguments. For Ruby methods that take a variable number of arguments, returns -n-1, where n is the number of required arguments." Signed-off-by: Guillermo Ramos <gramos@opennebula.io>
Signed-off-by: Victor Hansson <vhansson@opennebula.io> Co-authored-by: Tino Vázquez <cvazquez@opennebula.io>
This feature auto mounts NFS volumes for datastores. The behavior can be controlled with the following template attributes: - ANFS_ENABLE: YES/NO to enable the automatic NFS management - ANFS_HOST: hostname/IP of the NFS server - ANFS_PATH: of the NFS share for this datastore - ANFS_OPTS: Comma separated options (fstab-like) used for mounting the NFS shares The shared drivers also performs a "garbage-collector" like to unmount NFS volumes on the hypervisors when the datastores are deleted. This operation is performed in a "lazy" way, when VMs are deployed on the hypervisor. * oneimage create: mount/umount DS on demand Signed-off-by: Guillermo Ramos <gramos@opennebula.io> * Move sh mount/umount logic to libfs.sh Signed-off-by: Guillermo Ramos <gramos@opennebula.io> * oneimage delete: mount/umount DS on demand Signed-off-by: Guillermo Ramos <gramos@opennebula.io> * Limit NFS mount/umount from SH code to 30s Signed-off-by: Guillermo Ramos <gramos@opennebula.io> * oneimage clone: mount/umount DS on demand Signed-off-by: Guillermo Ramos <gramos@opennebula.io> * onevm deploy: mount DS on demand Signed-off-by: Guillermo Ramos <gramos@opennebula.io> * Temporal mount only when needed Signed-off-by: Guillermo Ramos <gramos@opennebula.io> * onevm deploy: mount DS on demand (persisten) Signed-off-by: Guillermo Ramos <gramos@opennebula.io> * Linter Signed-off-by: Guillermo Ramos <gramos@opennebula.io> * onevm deploy: umount unneeded DS Signed-off-by: Guillermo Ramos <gramos@opennebula.io> * Allow mount/umount/sed from sudoers Signed-off-by: Guillermo Ramos <gramos@opennebula.io> * Temporal mount: use NFS_AUTO_OPTS Signed-off-by: Guillermo Ramos <gramos@opennebula.io> * Do AutoNFS cleanup even during non-related ops Signed-off-by: Guillermo Ramos <gramos@opennebula.io> * Final refactor and improvements Signed-off-by: Guillermo Ramos <gramos@opennebula.io> * ro values for Datastore object * Wording for AutoNFS RO attributes Signed-off-by: Guillermo Ramos <gramos@opennebula.io> * NFS_AUTO_ENABLE: change 'true' to 'yes' Signed-off-by: Guillermo Ramos <gramos@opennebula.io> * sudoers: merge everythng into ONE_NFS Signed-off-by: Guillermo Ramos <gramos@opennebula.io> * Quote NFS_AUTO_OPTS Signed-off-by: Guillermo Ramos <gramos@opennebula.io> * Fix difference between sudoers specs Signed-off-by: Guillermo Ramos <gramos@opennebula.io> * Touch .automounted in AutoNFS mounts Signed-off-by: Guillermo Ramos <gramos@opennebula.io> * Update sudoers.rb * Update rm * Quote bash variable expansion Signed-off-by: Guillermo Ramos <gramos@opennebula.io> --------- Signed-off-by: Guillermo Ramos <gramos@opennebula.io> Co-authored-by: Ruben S. Montero <rsmontero@opennebula.org>
When the VM generates traffic addressed to the hypervisor it is handled as routed (not bridged) and handle through the INPUT chain (not the FORWARD chain). In this case, none of the iptables rules are applied to it so bypassing all SG rules, including anti-spoofing ones. This commit applies the egress rules to the VM traffic in this case. L #-: Liniting of fw driver B #-: Update call to DriverLogger to new structure (cherry picked from commit 3cc6e7af1f8c66619d6b8c446ee6e4de525bc298)
I make available my integration work on zfs, based on the ceph driver.
zfs is for single node and zfs_iscsi for shared
https://github.com/openmilanese/zfs_iscsi.git
https://github.com/openmilanese/zfs.git