Fix unit tests #8553
Merged
Fix unit tests #8553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
madhavajay
reviewed
Mar 13, 2024
| @@ -177,7 +177,7 @@ def run_container_using_docker( | |||
| image=worker_image.image_identifier.full_name_with_tag, | |||
| name=f"{hostname}-{worker_name}", | |||
| detach=True, | |||
| auto_remove=True, | |||
| # auto_remove=True, | |||
There was a problem hiding this comment.
How come we have commented this out?
There was a problem hiding this comment.
yeah this was to detect the errors in default worker pool, need to clean up this PR before we merge
|
I'll be pushing some more fixes, please don't merge this PR at the moment |
rasswanth-s
reviewed
Mar 13, 2024
| @@ -120,14 +120,14 @@ test_plugins = | |||
| pytest-asyncio | |||
| pytest-randomly | |||
| pytest-sugar | |||
| pytest_mock_resources | |||
| python_on_whales | |||
There was a problem hiding this comment.
MAYBE: I think we could also remove unsed dependencies here like
- python_on_whales
- lxml
- joblib (not fully sure if joblib is being used?)
There was a problem hiding this comment.
and I think pytest-asyncio is also not used
There was a problem hiding this comment.
Lets address in a smaller follow up PR.
rasswanth-s
reviewed
Mar 13, 2024
| bash -c "docker volume rm test-gateway-1_mongo-data --force || true" | ||
| bash -c "docker volume rm test-gateway-1_credentials-data --force || true" | ||
| bash -c "docker volume rm test-gateway-1_seaweedfs-data --force || true" | ||
| bash -c 'docker rm -f $(docker ps -a -q --filter "label=orgs.openmined.syft") || true' |
|
@yashgorana is this PR good to be merged ? |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change, the motivation, and any additional context that will help others understand your PR. If it closes one or more open issues, please tag them as described here.
Affected Dependencies
List any dependencies that are required for this change.
How has this been tested?
Checklist