Bumped to torch 2.2 and python 3.12 #8548
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fixed some raw string regex issues - deprecated python 3.9 - added python 3.12
instead of disabling it entirely
and upgrade pre-commit hooks
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
@shubham3121 most changes here are from ruff. Files need reviewing are |
|
@kiendang I see conflicts with recent dev, I will work on resolving it, first thing tomorrow. |
4 tasks
|
I resolved the conflicts. Protocol version's messed up again though due to the type annotation syntax change. |
Co-authored-by: Shubham Gupta <shubhamgupta3121@gmail.com>
kiendang
force-pushed
the
madhava/torch_cp12
branch
from
7ebf512 to
017d88e
Compare
|
Oh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change, the motivation, and any additional context that will help others understand your PR. If it closes one or more open issues, please tag them as described here.
Affected Dependencies
List any dependencies that are required for this change.
How has this been tested?
Checklist