keep attribute_id as keys in getFilterableAttributes ()

[empiricompany]

Description (*)

I found these issues with Mirasvit_Seofilter.
getFilterableAttributes() lost its keys after being reordered by position with usort.
In my case, Mirasvit_Seofilter expects an array where the keys must contain the IDs, then it calls array_keys() to compare them with the current filter.

// get all currently filterable attributes
$category = Mage::registry('current_category');
$filterableAttributes = Mage::getSingleton('seofilter/catalog_layer')->setCurrentCategory($category)->getFilterableAttributes();
// failure, if current attribute not filterable or the option does not belong to the given attribute model
if (!in_array($option['attribute_id'], array_keys($filterableAttributes))

after reordering with usort, it lost the attribute_id and reset the key like 0,1,2,3,4...

usort($attributes, function ($a, $b) {
    return $a->getPosition() - $b->getPosition();
});

returned array must be $attributes[$attributeId] = $attribute;

Manual testing scenarios (*)

1. call Mage_Catalog_Model_Layer::getFilterableAttributes()
2. get array of filterable attribute ids with array_keys()

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All automated tests passed successfully (all builds are green)

[github-actions]

Test Results

715 tests  ±0   688 ✅ +24   3s ⏱️ ±0s
163 suites ±0    27 💤  - 24 
  1 files   ±0     0 ❌ ± 0 

Results for commit c7e2b52. ± Comparison against base commit f48b6c0.

♻️ This comment has been updated with latest results.

[kiatng]

Ref line 217: $attributes[$attributeId] = $attribute;, the intention is to have attribute_id as keys

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[sreichel]

Not tested.