From 8f4e38aa2da40a00c5977d966ff2a43b690d7eab Mon Sep 17 00:00:00 2001 From: Arnaud Amant Date: Wed, 5 Feb 2025 08:23:18 +0100 Subject: [PATCH 1/2] fix error in column renderer when valud is empty and not null --- .../Mage/Adminhtml/Block/Widget/Grid/Column/Renderer/Number.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/code/core/Mage/Adminhtml/Block/Widget/Grid/Column/Renderer/Number.php b/app/code/core/Mage/Adminhtml/Block/Widget/Grid/Column/Renderer/Number.php index 279d80d5e9e..f3dc19f5edf 100644 --- a/app/code/core/Mage/Adminhtml/Block/Widget/Grid/Column/Renderer/Number.php +++ b/app/code/core/Mage/Adminhtml/Block/Widget/Grid/Column/Renderer/Number.php @@ -32,7 +32,7 @@ class Mage_Adminhtml_Block_Widget_Grid_Column_Renderer_Number extends Mage_Admin protected function _getValue(Varien_Object $row) { $data = parent::_getValue($row); - if (!is_null($data)) { + if (!empty($data)) { $value = $data * 1; $sign = (bool) (int) $this->getColumn()->getShowNumberSign() && ($value > 0) ? '+' : ''; if ($sign) { From eb3aacc1787281f6fda491a87e27758569baf6e7 Mon Sep 17 00:00:00 2001 From: Arnaud Amant Date: Thu, 13 Feb 2025 21:17:13 +0100 Subject: [PATCH 2/2] test if operand is numeric --- .../Mage/Adminhtml/Block/Widget/Grid/Column/Renderer/Number.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/code/core/Mage/Adminhtml/Block/Widget/Grid/Column/Renderer/Number.php b/app/code/core/Mage/Adminhtml/Block/Widget/Grid/Column/Renderer/Number.php index f3dc19f5edf..fbbc0eaccc8 100644 --- a/app/code/core/Mage/Adminhtml/Block/Widget/Grid/Column/Renderer/Number.php +++ b/app/code/core/Mage/Adminhtml/Block/Widget/Grid/Column/Renderer/Number.php @@ -32,7 +32,7 @@ class Mage_Adminhtml_Block_Widget_Grid_Column_Renderer_Number extends Mage_Admin protected function _getValue(Varien_Object $row) { $data = parent::_getValue($row); - if (!empty($data)) { + if (is_numeric($data)) { $value = $data * 1; $sign = (bool) (int) $this->getColumn()->getShowNumberSign() && ($value > 0) ? '+' : ''; if ($sign) {