-
-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix error in column renderer when valud is empty and not null #4601
base: main
Are you sure you want to change the base?
Conversation
Thanks. Whats the error message? Can you provide steps to reproduce? |
Please add error message and stacktrace. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The value of empty('0')
is true
, so this would change the behavior such that '0' renders the default value rather than '0'.
I've updated the test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My test: https://onlinephp.io/c/38a62
|
Description (*)
fix class Mage_Adminhtml_Block_Widget_Grid_Column_Renderer_Number when value is empty