Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix error in column renderer when valud is empty and not null #4601

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

aamant
Copy link

@aamant aamant commented Feb 5, 2025

Description (*)

fix class Mage_Adminhtml_Block_Widget_Grid_Column_Renderer_Number when value is empty

@github-actions github-actions bot added the Component: Adminhtml Relates to Mage_Adminhtml label Feb 5, 2025
@sreichel
Copy link
Contributor

sreichel commented Feb 5, 2025

Thanks. Whats the error message?

Can you provide steps to reproduce?

@aamant
Copy link
Author

aamant commented Feb 5, 2025

This error occurs when the expected value is empty but not null

Capture d’écran 2025-02-05 à 10 05 15

@sreichel
Copy link
Contributor

sreichel commented Feb 5, 2025

This error occurs

Please add error message and stacktrace.

@aamant
Copy link
Author

aamant commented Feb 5, 2025

Capture d’écran 2025-02-05 à 12 11 36

Copy link
Member

@colinmollenhour colinmollenhour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The value of empty('0') is true, so this would change the behavior such that '0' renders the default value rather than '0'.

@aamant
Copy link
Author

aamant commented Feb 13, 2025

I've updated the test

Copy link
Contributor

@kiatng kiatng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Adminhtml Relates to Mage_Adminhtml
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants