Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump phpstan/phpstan from 1.10.44 to 1.10.50 #3698

Merged
merged 18 commits into from
Feb 8, 2024
Merged

Bump phpstan/phpstan from 1.10.44 to 1.10.50 #3698

merged 18 commits into from
Feb 8, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 11, 2023 •
edited
Loading

Bumps phpstan/phpstan from 1.10.44 to 1.10.48.

Release notes

Sourced from phpstan/phpstan's releases.

1.10.48

Bleeding edge 🔪

If you want to see the shape of things to come and adopt bleeding edge features early, you can include this config file in your project's phpstan.neon:

includes:
	- vendor/phpstan/phpstan/conf/bleedingEdge.neon

Of course, there are no backwards compatibility guarantees when you include this file. The behaviour and reported errors can change in minor versions with this file included. Learn more

Improvements 🔧

Bugfixes 🐛

Function signature fixes 🤖

1.10.47

Improvements 🔧

... (truncated)

Commits
  • 087ed4b PHPStan 1.10.48
  • 8ada96c Update baselines
  • fa5d5f9 Updated PHPStan to commit fa5d5f958b051b088fb0824d377a091273d6436c
  • 34dfd6a Updated PHPStan to commit 34dfd6aa45963c83cb5f733dae4890ed1a63cbda
  • cf2c8bb Updated PHPStan to commit cf2c8bbd9ebd2ebe300dbd310e136ad603d7def3
  • a1fffb3 Updated PHPStan to commit a1fffb3346e09f1e8e8d987d4282263295a55142
  • 3a12724 Updated PHPStan to commit 3a12724fd636b1bcf36c22b36e8f765d97150895
  • 0a3a968 Updated PHPStan to commit 0a3a968b86773a54e102baee4f63d39a556c97fc
  • 1b126c9 Updated PHPStan to commit 1b126c9a49ec934b381e35a58bf412292762cbef
  • 942eaa4 Update baselines
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot
Bump phpstan/phpstan from 1.10.44 to 1.10.48
a66d84b 
Bumps [phpstan/phpstan](https://github.com/phpstan/phpstan) from 1.10.44 to 1.10.48.
- [Release notes](https://github.com/phpstan/phpstan/releases)
- [Changelog](https://github.com/phpstan/phpstan/blob/1.11.x/CHANGELOG.md)
- [Commits](phpstan/phpstan@1.10.44...1.10.48)

---
updated-dependencies:
- dependency-name: phpstan/phpstan
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file PATCH This PR is intended to be treated as a PATCH according to RFC-0002 php Pull requests that update Php code labels Dec 11, 2023
@dependabot dependabot bot mentioned this pull request Dec 11, 2023
Closed
@fballiano
Copy link
Contributor

all of the errors should be fixed now

fballiano
fballiano previously approved these changes Dec 11, 2023
View reviewed changes
addison74
addison74 previously approved these changes Dec 13, 2023
View reviewed changes
@dependabot Dependabot
Copy link
Contributor Author

dependabot bot commented on behalf of github Dec 18, 2023

A newer version of phpstan/phpstan exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@fballiano fballiano dismissed stale reviews from addison74 and themself via af113e4 December 19, 2023 17:50
@fballiano fballiano changed the title Bump phpstan/phpstan from 1.10.44 to 1.10.48 Bump phpstan/phpstan from 1.10.44 to 1.10.50 Dec 19, 2023
@fballiano fballiano removed the PATCH This PR is intended to be treated as a PATCH according to RFC-0002 label Dec 19, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 19, 2023 •
edited
Loading

Test Results

7 tests   7 ✔️  0s ⏱️
3 suites  0 💤
1 files    0 ❌

Results for commit 85fe6be.

♻️ This comment has been updated with latest results.

@fballiano
Copy link
Contributor

I don't know why phpstan is complaining now because those methods don't return null anywhere I think

@sreichel
Copy link
Contributor

Think error-format changed. Error is still there.

Mage_Install_IndexController::preDispatch returns void (from parent comment), but there is ...

rerturn parent:preDispatch();

This should fix it ...

parent:preDispatch();
rerturn;

@fballiano
Copy link
Contributor

but the parent:preDispatch() seems to only return void 🧐 I thought it would work...

@sreichel
Copy link
Contributor

Problem is, it resolves to return <parent:void>, but you cant return a void "value".

@sreichel
Copy link
Contributor

Removing return may change some behavoir?

@fballiano
Copy link
Contributor

the parent method doesn't return anything and AFAIK not having a return should be the same as a return; instruction, as far as I know :-)

@sreichel
Copy link
Contributor

You re right. dont need return here.

@github-actions github-actions bot added Component: Checkout Relates to Mage_Checkout Component: Sales Relates to Mage_Sales Component: Install Relates to Mage_Install composer Relates to composer.json phpstan labels Dec 26, 2023
@fballiano fballiano requested a review from addison74 February 5, 2024 10:56
addison74
addison74 previously approved these changes Feb 5, 2024
View reviewed changes
@fballiano fballiano requested a review from Flyingmana February 6, 2024 10:20
@fballiano fballiano requested a review from kiatng February 7, 2024 11:20
@fballiano fballiano merged commit 0f15166 into main Feb 8, 2024
28 checks passed
@fballiano fballiano deleted the dependabot/composer/phpstan/phpstan-1.10.48 branch February 8, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fballiano fballiano fballiano left review comments

@kiatng kiatng kiatng approved these changes

@sreichel sreichel sreichel approved these changes

@addison74 addison74 addison74 left review comments

@Flyingmana Flyingmana Awaiting requested review from Flyingmana

Assignees
No one assigned
Labels
Component: Checkout Relates to Mage_Checkout Component: Install Relates to Mage_Install Component: Sales Relates to Mage_Sales composer Relates to composer.json dependencies Pull requests that update a dependency file php Pull requests that update Php code phpstan
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fballiano @sreichel @kiatng @addison74